[1.21.4] Port of #527 Changes #529
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build failed due to gradle being out of date for current NeoGradle so I updated Gradle to Latest along with Loom to match it, and built. Also went ahead and removed the Forge jopt simple hack as it is no longer needed indev if you use the latest forge as it got patched. Some other small things I added was removing the use of FMLJavaModLoadingContext.get() from Forge as it is Marked for Removal, along with bumping the pack.mcmeta to 61. Built and tested all works, I will forward port these changes once the pr is approved