This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Created FusedExplosive interface. #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a huge problem with the implementation of explosives that Glowstone will have to decide whether or not it wants to include the same "bugs". This means that this PR is on hold indefinitely and will not get reviewed until explosive entities, and their events, are implemented in Glowstone. |
|
Ok sounds reasonable. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue:
Currently there are no interface similarities between MinecartTNT+Creeper but both entities are Explosives and have a Fuse. It is not possible to specify the explosion range for both of them.
Justification for this PR:
Creeper+MinecartTNT are Explosives, but their interface declaration does not specify that.
Both explosives also have a fuse so there is an additional interface for FusedExplosives.
PR Breakdown:
This PR add a FusedExplosive interface and add it to all applicable entities. (Creeper, MinecartTNT)
In addition to that it adds the missing ExplosionPrimeEvent to MinecartTNT. (Has not been "Explosive" before)
In adddition to that it adds the ExplosiveFuseStartEvent which is called when the FusedExplosives is fused.
Testing Results and Materials:
(Compiled for Bukkit and tested with CraftBukkit)
https://dl.dropboxusercontent.com/u/16999313/Bukkit/FusedExplosivesTest-1.0.jar (Plugin)
https://dl.dropboxusercontent.com/u/16999313/Bukkit/FusedExplosivesTest.zip (Plugin-Sources)
Old PR(s):
Bukkit#993