Merge pull request #199 from Glutexo/component

Use Map instead of Module.safe_concat
Glutexo · Nov 4, 2023 · 4874162 · 4874162
2 parents 2b2c2ef + fffc5d3
commit 4874162
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/cli.ex b/lib/cli.ex
@@ -1,7 +1,11 @@
 defmodule Onigumo.CLI do
+  @components %{
+    :Downloader => Onigumo.Downloader
+  }
+
   def main(argv) do
     {[], [component]} = OptionParser.parse!(argv, strict: [])
-    module = Module.safe_concat("Onigumo", component)
+    {:ok, module} = Map.fetch(@components, String.to_atom(component))
     root_path = File.cwd!()
     module.main(root_path)
   end

diff --git a/test/onigumo_cli_test.exs b/test/onigumo_cli_test.exs
@@ -22,7 +22,7 @@ defmodule OnigumoCLITest do
     end
 
     test("run CLI with invalid argument") do
-      assert_raise(ArgumentError, fn -> Onigumo.CLI.main(["Uploader"]) end)
+      assert_raise(MatchError, fn -> Onigumo.CLI.main(["Uploader"]) end)
     end
 
     test("run CLI with no arguments") do