Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse working_dir switch #195

Merged
merged 24 commits into from
May 10, 2024
Merged

Parse working_dir switch #195

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
3d4cca5
Parse switches output and component from CLI
nappex Jun 9, 2023
bec0fe6
Fix formatting
nappex Jun 9, 2023
6d4929d
Merge branch 'master' into cli-work-dir
nappex Oct 3, 2023
56acd64
Parse working_dir switch
nappex Oct 15, 2023
31ff6d7
Merge branch 'master' into cli-work-dir
nappex Feb 24, 2024
3b30377
Parse a new switch --working-dir from CLI
nappex Feb 24, 2024
4e5fa37
Merge branch 'master' into parse-working-dir
Glutexo Mar 16, 2024
25c5b16
Merge branch 'cli-work-dir' into parse-working-dir
nappex Mar 16, 2024
b0a4b89
Rename variable 'root_path' to 'working_dir'
nappex Mar 16, 2024
4a11e4e
Update help message with usage of --working-dir
nappex Mar 16, 2024
02c0b2c
Add shorthand version for switch --working-dir
nappex Mar 16, 2024
e8467f0
Merge branch 'master' into parse-working-dir
nappex Apr 6, 2024
9452872
Add tests for working_dir switch usage
nappex Apr 6, 2024
d6a9b96
Merge branch 'master' into parse-working-dir
nappex Apr 7, 2024
0988b13
Improve usage message for working_dir switch
nappex Apr 20, 2024
a5e9edc
Parametrize tests for working_dir switch with long and short
nappex Apr 20, 2024
9fbdbaf
Be consistent with naming of variables in tests with the code
nappex Apr 20, 2024
c73a42f
Use inspect to print string in all descriptions of tests
nappex Apr 20, 2024
47e06ed
Test switch --working-dir without value
nappex Apr 20, 2024
b3c5bf3
Test switch --working-dir with value '.'
nappex Apr 20, 2024
f883c28
Fix formatting
nappex Apr 20, 2024
e57bfa7
Update CLI help message for working dir
nappex May 10, 2024
e227fb2
Parametrize all tests with working-dir switch
nappex May 10, 2024
4120a34
Remove test with no additional value
nappex May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/cli.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
defmodule Onigumo.CLI do
def main(argv) do
{[], [component]} = OptionParser.parse!(argv, strict: [])
{parsed_switches, [component]} = OptionParser.parse!(argv, strict: [working_dir: :string])
module = Module.safe_concat("Onigumo", component)
root_path = File.cwd!()
module.main(root_path)

parsed_switches
|> Keyword.get(:working_dir, File.cwd!())
|> module.main
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Elixir style guide suggests using parentheses in the pipe operator.

Use parentheses for one-arity functions when using the pipe operator (|>).

Suggested change
|> module.main
|> module.main()

I’d generally incline towards using them for functions without an argument, mainly for consistency. The Guide considers that preferred, although in other examples they use them without parens a lot themselves.

Use parentheses in function calls, especially inside a pipeline.

end
end