Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a component behavior #201

Merged
merged 3 commits into from
Nov 4, 2023
Merged

Define a component behavior #201

merged 3 commits into from
Nov 4, 2023

Conversation

Glutexo
Copy link
Owner

@Glutexo Glutexo commented Nov 4, 2023

Introduced a component behavior and implemented it for Downloader. This creates a clear interface between the callers, now CLI and a Supervisor in the future, and the actual component modules. Also this makes the Downloader mockable and thus unit-testable without repeating the internal logic of the actual Downloader.

Resolves #198.

All components are going to have a common behavior. Both the CLI and a
possible future Supervisor are going to treat components as blackboxes
using their interface.
It is considered a good practice to mark the concrete behavior that a
method belongs to.
@Glutexo Glutexo requested a review from nappex November 4, 2023 18:53
@Glutexo Glutexo self-assigned this Nov 4, 2023
@nappex nappex merged commit 59a6535 into master Nov 4, 2023
1 check passed
@Glutexo Glutexo deleted the behaviour branch December 13, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use function instead name of module of specific module
2 participants