Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split cli messages to case with invalid usage and help message #242

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

nappex
Copy link
Collaborator

@nappex nappex commented Aug 25, 2024

fix #240

One would be help message

another perhaps usage message for invalid usage of onifumo

This PR is done above the PR #238, because it is nature continuation of it.

Before merging this to master must be ensured merge of #238 to #242

@nappex
Copy link
Collaborator Author

nappex commented Aug 25, 2024

Revise tests! 😈

@nappex
Copy link
Collaborator Author

nappex commented Dec 17, 2024

--help must be used as only one cli argument to run correctly, we do not want behaviour as "rule them all" by help switch as proposed in PR #244 .
If someone use --help with other argument or switch, then it could evoke to user it should output help for certain argument resp. switch. We do not want to implement this feature currently, maybe later. So --help should be used only for general help message for whole Onigumo not for its individual commands.

@Glutexo
Copy link
Owner

Glutexo commented Jan 4, 2025

The -h/--help is introduced in a separate pull request #238. This pull request should only introduce the help message.

@Glutexo Glutexo self-requested a review January 4, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split usage_message and help_message
2 participants