Fix #129

pkg/xsd/schema.go

@@ -162,8 +162,22 @@ func (sch *Schema) encodingXmlImportNeeded() bool {
 	return len(sch.Elements) != 0 || len(sch.ComplexTypes) != 0
 }
 
+func deduplicateElementsLossfree(elements []Element) []Element {
+	seen := make(map[string]int, len(elements))
+	for j, element := range elements {
+		dupeCount, dupe := seen[element.GoName()]
+		if !dupe {
+			seen[element.GoName()] = 1
+			continue
+		}
+		elements[j].nameOverride = fmt.Sprintf("%s-%d", element.GoName(), dupeCount)
+		seen[element.GoName()]++
+	}
+	return elements
+}
+
 func (sch *Schema) ExportableElements() []Element {
-	return append(sch.Elements, sch.inlinedElements...)
+	return deduplicateElementsLossfree(append(sch.Elements, sch.inlinedElements...))
 }
 
 func (sch *Schema) ExportableComplexTypes() []ComplexType {

tests/xsd-examples/valid/issue129.xsd

@@ -0,0 +1,31 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<xsd:schema xmlns:xsd="http://www.w3.org/2001/XMLSchema"
+            elementFormDefault="qualified" attributeFormDefault="qualified" version="1.0">
+    <xsd:annotation/>
+    <xsd:complexType name="AAA">
+        <xsd:annotation/>
+        <xsd:sequence>
+            <xsd:element name="List" minOccurs="0">
+                <xsd:annotation/>
+                <xsd:complexType>
+                    <xsd:sequence>
+                        <xsd:element name="CCC" type="xsd:string" minOccurs="1" maxOccurs="unbounded"/>
+                    </xsd:sequence>
+                </xsd:complexType>
+            </xsd:element>
+        </xsd:sequence>
+    </xsd:complexType>
+    <xsd:complexType name="BBB">
+        <xsd:annotation/>
+        <xsd:sequence>
+            <xsd:element name="List" minOccurs="0">
+                <xsd:annotation/>
+                <xsd:complexType>
+                    <xsd:sequence>
+                        <xsd:element name="DDD" type="xsd:int" minOccurs="1" maxOccurs="unbounded"/>
+                    </xsd:sequence>
+                </xsd:complexType>
+            </xsd:element>
+        </xsd:sequence>
+    </xsd:complexType>
+</xsd:schema>

tests/xsd-examples/valid/issue129.xsd.out

@@ -0,0 +1,37 @@
+// Code generated by https://github.com/gocomply/xsd2go; DO NOT EDIT.
+// Models for
+package issue129
+
+import (
+	"encoding/xml"
+)
+
+// Element
+type List struct {
+	XMLName xml.Name `xml:"List"`
+
+	Ccc []string `xml:",any"`
+}
+
+// Element
+type List1 struct {
+	XMLName xml.Name `xml:"List"`
+
+	Ddd []int `xml:",any"`
+}
+
+// XSD ComplexType declarations
+
+type Aaa struct {
+	XMLName xml.Name
+
+	List *List `xml:",any"`
+}
+
+type Bbb struct {
+	XMLName xml.Name
+
+	List *List `xml:",any"`
+}
+
+// XSD SimpleType declarations