Convert addon ".material" files to ".tres" files #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR converts the addon ".material" binary files to the ".tres" text files to better handle source control and reviewing changes.
|
lgtm, no issues found |
BastiaanOlij
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
I think we can get away with putting this into 4.3.1, definitely makes it easier to maintain.
One thing that is important, but I think this should always be the case, is that textures should always be separate from the material. Embedded textures in tres files become HUGE. This can happen depending on the import format and settings being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #578 by converting the addon ".material" binary files to ".tres" text files to better handle source control and reviewing changes.