Use node v16.14.2 (#2743)

* Update to node 16

* 16.14.2 everywhere

.cloudbuild/external.yaml

@@ -4,34 +4,34 @@
 timeout: 900s # set build timeout to 15 mins
 
 steps:
-  - name: node:14
+  - name: node:16.14.2
     id: 'Install dependencies'
     entrypoint: npm
     args: ['ci']
 
-  - name: node:14
+  - name: node:16.14.2
     id: 'Configure secrets'
     entrypoint: npm
     args: ['run', 'cloud-secrets']
 
-  - name: node:14
+  - name: node:16.14.2
     id: 'Build external data'
     entrypoint: npm
     args: ['run', 'build-external']
     env:
-    - 'NODE_ENV=production'
+      - 'NODE_ENV=production'
 
-  - name: node:14
+  - name: node:16.14.2
     id: 'Create .eleventyignore file'
     entrypoint: npm
     args: ['run', 'ignore']
     env:
-    # TODO: We should try to remove more stuff here, because it's supposed to
-    # be a fast build to sanity-check output.
-    # It needs to include extensions and API generation.
-    - 'ELEVENTY_IGNORE_NACL=true'
+      # TODO: We should try to remove more stuff here, because it's supposed to
+      # be a fast build to sanity-check output.
+      # It needs to include extensions and API generation.
+      - 'ELEVENTY_IGNORE_NACL=true'
 
-  - name: node:14
+  - name: node:16.14.2
     id: 'Build eleventy in dev mode to confirm'
     entrypoint: npm
     args: ['run', 'eleventy']
@@ -41,11 +41,11 @@ steps:
     id: 'Synchronize content to external-dcc-data bucket'
     entrypoint: bash
     args:
-    - '-c'
-    - |
-      gsutil rsync external/data/ gs://external-dcc-data
+      - '-c'
+      - |
+        gsutil rsync external/data/ gs://external-dcc-data
 
 options:
   env:
-  - 'PROJECT_ID=$PROJECT_ID'
-  - 'NODE_OPTIONS=--unhandled-rejections=strict'
+    - 'PROJECT_ID=$PROJECT_ID'
+    - 'NODE_OPTIONS=--unhandled-rejections=strict'

.cloudbuild/version-check.yaml

@@ -1,20 +1,19 @@
 # This Cloud Build task can kick off our actual deploy if the hash has changed.
 
 steps:
-  - name: node:14
+  - name: node:16.14.2
     id: 'Install dependencies'
     entrypoint: npm
     args: ['ci']
 
-  - name: node:14
+  - name: node:16.14.2
     id: 'Verify and maybe kick off build for new version'
     entrypoint: npm
     args: ['run', 'version-check']
     env:
-    - 'PROJECT_ID=$PROJECT_ID'
-    - 'NODE_ENV=production'
+      - 'PROJECT_ID=$PROJECT_ID'
+      - 'NODE_ENV=production'
 
 options:
   env:
-  - 'PROJECT_ID=$PROJECT_ID'
-  - 'NODE_OPTIONS=--unhandled-rejections=strict'
+    - 'PROJECT_ID=$PROJECT_ID'

.github/workflows/check.yml

@@ -12,21 +12,15 @@ jobs:
       NODE_OPTIONS: --max_old_space_size=4096 --unhandled-rejections=strict
     steps:
       - name: Checkout
-        uses: actions/checkout@v1.0.0
+        uses: actions/checkout@v3
       - name: Setup node
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v3
         with:
-          node-version: '14.x'
-      - name: Cache node_modules
-        uses: actions/cache@v1
-        with:
-          path: ~/.npm
-          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
-          restore-keys: |
-            ${{ runner.os }}-node-
+          node-version: 'v16.14.2'
+          cache: 'npm'
       - name: Install
         run: npm ci
-      
+
       # Checks to see if any files in the PR match one of the listed file types.
       # We can use this filter to decide whether or not to run linters or tests.
       # You can check if a file with a listed file type is in the PR by doing:
@@ -51,7 +45,7 @@ jobs:
               - '**/*.njk'
             _external:
               - 'external/**/*'
-      
+
       # Use the filter to check if files with a specific file type were changed
       # in the PR. If they were, run the relevant linters. Otherwise, skip.
 
@@ -82,4 +76,4 @@ jobs:
       # Only run tests if the PR touches behavior related files.
       - name: Test
         if: ${{ steps.filter.outputs.js == 'true' || steps.filter.outputs.json == 'true' || steps.filter.outputs.yml == 'true' || steps.filter.outputs.njk == 'true'}}
-        run: npm run test
+        run: npm run test

.github/workflows/lighthouse-ci.yml

@@ -16,22 +16,16 @@ jobs:
     if: ${{ github.repository == 'GoogleChrome/developer.chrome.com' }}
     runs-on: ubuntu-latest
     env:
-      # Increase RAM limit, and make uncaught exceptions crash (default in 16+).
-      NODE_OPTIONS: --max_old_space_size=4096 --unhandled-rejections=strict
+      # Increase RAM limit.
+      NODE_OPTIONS: --max_old_space_size=8192
     steps:
       - name: Checkout
-        uses: actions/checkout@v1.0.0
+        uses: actions/checkout@v3
       - name: Setup node
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v3
         with:
-          node-version: '14.x'
-      - name: Cache node_modules
-        uses: actions/cache@v1
-        with:
-          path: ~/.npm
-          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
-          restore-keys: |
-            ${{ runner.os }}-node-
+          node-version: 'v16.14.2'
+          cache: 'npm'
       - name: Install
         run: npm ci
       - name: Build

.github/workflows/percy.yml

@@ -28,21 +28,15 @@ jobs:
       NODE_OPTIONS: --max_old_space_size=4096 --unhandled-rejections=strict
     steps:
       - name: Checkout
-        uses: actions/checkout@v1.0.0
+        uses: actions/checkout@v3
       - name: Setup node
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v3
         with:
-          node-version: '14.x'
-      - name: Cache node_modules
-        uses: actions/cache@v1
-        with:
-          path: ~/.npm
-          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
-          restore-keys: |
-            ${{ runner.os }}-node-
+          node-version: 'v16.14.2'
+          cache: 'npm'
       - name: Install
         run: npm ci
       - name: Percy
         env:
           PERCY_TOKEN: ${{ secrets.PERCY_TOKEN }}
-        run: npm run percy
+        run: npm run percy

.github/workflows/repo-sync.yml

@@ -2,8 +2,8 @@ name: Repo Sync
 
 on:
   schedule:
-  # Every 3 hours
-  - cron:  '0 */3 * * *'
+    # Every 3 hours
+    - cron: '0 */3 * * *'
   # Allow the action to be manually run
   workflow_dispatch:
 
@@ -12,13 +12,13 @@ jobs:
     if: ${{ github.repository == 'GoogleChrome/dcc-private' }}
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-      with:
-        persist-credentials: false
-    - name: repo-sync
-      uses: repo-sync/github-sync@v2
-      with:
-        source_repo: "GoogleChrome/developer.chrome.com"
-        source_branch: "main"
-        destination_branch: "main"
-        github_token: ${{ secrets.GITHUB_TOKEN }}
+      - uses: actions/checkout@v3
+        with:
+          persist-credentials: false
+      - name: repo-sync
+        uses: repo-sync/github-sync@v2
+        with:
+          source_repo: 'GoogleChrome/developer.chrome.com'
+          source_branch: 'main'
+          destination_branch: 'main'
+          github_token: ${{ secrets.GITHUB_TOKEN }}

.nvmrc

@@ -1 +1 @@
-v14.15.0
+v16.14.2

package.json

@@ -133,5 +133,8 @@
     "unist-util-visit": "^2.0.3",
     "uslug": "^1.0.4",
     "wicg-inert": "^3.0.3"
+  },
+  "volta": {
+    "node": "16.14.2"
   }
 }