Skip to content

Commit

Permalink
duh
Browse files Browse the repository at this point in the history
  • Loading branch information
connorjclark committed Dec 14, 2023
1 parent ac2f746 commit ab4fa44
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/cli/test/assert.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ describe('Lighthouse CI assert CLI', () => {
it('should run the no-pwa preset', async () => {
const result = await run([`--preset=lighthouse:no-pwa`]);
expect(result.status).toEqual(1);
expect(result.failures.length).toMatchInlineSnapshot(`68`);
expect(result.warnings.length).toMatchInlineSnapshot(`0`);
expect(result.failures.length).toMatchInlineSnapshot(`91`);
expect(result.warnings.length).toMatchInlineSnapshot(`16`);
expect(result.passes.length).toMatchInlineSnapshot(`0`);
expect(result.failures).toContain('deprecations failure');
expect(result.failures).not.toContain('viewport failure');
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/test/collect-puppeteer.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ describe('Lighthouse CI collect CLI with puppeteer', () => {
const files = fs.readdirSync(path.join(autorunDir, '.lighthouseci'));
const report = files.find(file => /lhr.*\.json$/.test(file));
const lhr = JSON.parse(fs.readFileSync(path.join(autorunDir, '.lighthouseci', report)));
expect(lhr.userAgent).toContain('Chrome/111.0.0.0'); // make sure the right chrome was used
expect(lhr.userAgent).toContain('Chrome/119.0.0.0'); // make sure the right chrome was used
}, 180000);

it('should not fail on providing defaults without Chrome installations', async () => {
Expand Down

0 comments on commit ab4fa44

Please sign in to comment.