-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add psycopg 2.9.10 into requirements-test.txt #407
chore: Add psycopg 2.9.10 into requirements-test.txt #407
Conversation
From latest mypy, enum members can't be annotated anymore: https://mypy.readthedocs.io/en/stable/changelog.html#change-to-enum-membership-semantics
@enocom After this change is merged, can we remove the branch protection setting on |
You'll have to change the branch protection settings before merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up.
Small note: this is a "chore" since there's no meaningful user facing feature (right?). |
Thanks. Yes, that makes sense |
612ef4a
to
c8edf65
Compare
c8edf65
to
40bacbb
Compare
Had to make a small change to this that requires approval. The |
psycopg 2.9.10 is supported on Python 3.13 for Windows now: psycopg/psycopg2#1736. So we can add psycopg 2.9.10 into requirements-test.txt.
This change does the following:
psycopg2
intorequirement-tests.txt
.tests.yml
, run the Python 3.13 unit tests onmacos-latest
, but run the Python 3.9 unit tests only onmacos-12
.test_psycopg2_direct_connection.py
back intotests/system
folder because it can now run sincepsycopg2
is inrequirements-test.txt
.