Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add psycopg 2.9.10 into requirements-test.txt #407

Conversation

rhatgadkar-goog
Copy link
Collaborator

@rhatgadkar-goog rhatgadkar-goog commented Jan 6, 2025

psycopg 2.9.10 is supported on Python 3.13 for Windows now: psycopg/psycopg2#1736. So we can add psycopg 2.9.10 into requirements-test.txt.

This change does the following:

@rhatgadkar-goog rhatgadkar-goog marked this pull request as ready for review January 6, 2025 20:06
@rhatgadkar-goog rhatgadkar-goog requested a review from a team as a code owner January 6, 2025 20:06
@rhatgadkar-goog rhatgadkar-goog assigned enocom and unassigned nancynh Jan 6, 2025
@rhatgadkar-goog
Copy link
Collaborator Author

@enocom After this change is merged, can we remove the branch protection setting on unit tests (macos-latest, 3.9) and add one for unit tests (macos-12, 3.9)?

@enocom
Copy link
Member

enocom commented Jan 6, 2025

You'll have to change the branch protection settings before merging this.

Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up.

@enocom enocom changed the title feat: Add psycopg 2.9.10 into requirements-test.txt chore: Add psycopg 2.9.10 into requirements-test.txt Jan 6, 2025
@enocom
Copy link
Member

enocom commented Jan 6, 2025

Small note: this is a "chore" since there's no meaningful user facing feature (right?).

@rhatgadkar-goog
Copy link
Collaborator Author

Small note: this is a "chore" since there's no meaningful user facing feature (right?).

Thanks. Yes, that makes sense

@rhatgadkar-goog rhatgadkar-goog force-pushed the 388-remove-psycopg-from-requirements-testtxt-until-psycopg-2910-is-supported-on-python-313 branch 2 times, most recently from 612ef4a to c8edf65 Compare January 7, 2025 23:55
@rhatgadkar-goog rhatgadkar-goog force-pushed the 388-remove-psycopg-from-requirements-testtxt-until-psycopg-2910-is-supported-on-python-313 branch from c8edf65 to 40bacbb Compare January 8, 2025 00:03
@rhatgadkar-goog
Copy link
Collaborator Author

Had to make a small change to this that requires approval. The macos-12 runner is not supported anymore: actions/runner-images#10721. So the unit tests (macos-12, 3.9) test was failing. I instead modified requirements-test.txt to install psycopg 2.9.9 on Python 3.9 for MacOS.

@rhatgadkar-goog rhatgadkar-goog requested a review from enocom January 8, 2025 00:10
@rhatgadkar-goog rhatgadkar-goog merged commit 40bada7 into main Jan 8, 2025
15 checks passed
@rhatgadkar-goog rhatgadkar-goog deleted the 388-remove-psycopg-from-requirements-testtxt-until-psycopg-2910-is-supported-on-python-313 branch January 8, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove psycopg from requirements-test.txt until psycopg 2.9.10 is supported on Python 3.13
3 participants