Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dependency mysql:mysql-connector-java with com.mysql:mysql-connector-j 8.0.33 #338

Conversation

renovate-bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
mysql:mysql-connector-java compile replacement 8.0.33 -> 8.0.33

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

This is a special PR that replaces mysql:mysql-connector-java with the community suggested minimal stable replacement version.


Configuration

📅 Schedule: Branch creation - "* 0-3 * * 1" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label Feb 3, 2025
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request, submitted by Renovate Bot, aims to update the MySQL Connector/J dependency. The key change is replacing mysql:mysql-connector-java with com.mysql:mysql-connector-j version 8.0.33.

Here's a breakdown:

  • Intent: Upgrade the MySQL database connector to the latest stable version.
  • Changes:
    • The pom.xml file in the applications/proberapp directory has been modified. Specifically, lines 171 and 172 were changed to update the dependency's groupId and artifactId from mysql:mysql-connector-java to com.mysql:mysql-connector-j, while keeping the version at 8.0.33.
--- a/applications/proberapp/pom.xml
+++ b/applications/proberapp/pom.xml
@@ -168,8 +168,8 @@
             <scope>compile</scope>
         </dependency>
         <dependency>
-            <groupId>mysql</groupId>
-            <artifactId>mysql-connector-java</artifactId>
+            <groupId>com.mysql</groupId>
+            <artifactId>mysql-connector-j</artifactId>
             <version>8.0.33</version>
         </dependency>
         <dependency>
  • Activity: The pull request was automatically generated by Renovate, a dependency update bot. It's currently awaiting manual merge.

I'll provide a more detailed review shortly.


A little poem for your coding pleasure:

Dependencies change,
Renovate makes the update,
Code compiles clean.

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request replaces the mysql:mysql-connector-java dependency with com.mysql:mysql-connector-j. This change aligns with community recommendations and uses the minimal stable replacement version, which is a positive step towards better maintainability and compatibility. The version remains 8.0.33, ensuring consistency. However, it's crucial to thoroughly test this change to ensure no regressions are introduced, especially concerning database connectivity and interactions within the proberapp application. Consider adding a brief note to the release notes or README about this dependency update. I've also noticed the hardcoded database credentials in the pom.xml file, which is a security risk. While outside the scope of this PR, I strongly recommend addressing this by using environment variables or a more secure configuration management approach.

@copybara-service copybara-service bot merged commit a3ad114 into GoogleCloudPlatform:main Feb 3, 2025
7 checks passed
@renovate-bot renovate-bot deleted the renovate/mysql-mysql-connector-java-replacement branch February 3, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ready to pull
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants