Skip to content
This repository has been archived by the owner on Feb 18, 2025. It is now read-only.

Updates for warnings and deprecations #47

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Updates for warnings and deprecations #47

merged 2 commits into from
Oct 26, 2022

Conversation

rocpoc
Copy link
Contributor

@rocpoc rocpoc commented Oct 17, 2022

fix version constraint in provider block and add enable_private_endpoint in the google_container_cluster private_cluster_config block.

remove version constraint in `provider` block
@google-cla
Copy link

google-cla bot commented Oct 17, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Add required `enable_private_endpoint = false` in `private_cluster_config` block.
Copy link
Contributor

@dylanmpeck dylanmpeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaariger kaariger merged commit c1b96ac into GoogleCloudPlatform:master Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants