Adding changes based on review comments

GoogleCloudPlatform · Jan 10, 2025 · 265165b · 265165b
1 parent 1cbb09b
commit 265165b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/mmv1/products/chronicle/ReferenceList.yaml b/mmv1/products/chronicle/ReferenceList.yaml
@@ -1,4 +1,4 @@
-# Copyright 2024 Google Inc.
+# Copyright 2025 Google Inc.
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
@@ -35,8 +35,6 @@ examples:
     min_version: 'beta'
     vars:
       reference_list_id: reference_list_id
-      description: referencelist-description
-      reference_list_entry_value: "referencelist-entry-value"
     test_env_vars:
       chronicle_id: 'CHRONICLE_ID'
 
@@ -133,7 +131,6 @@ properties:
     description: |2-
 
       Possible values:
-      REFERENCE_LIST_SYNTAX_TYPE_UNSPECIFIED
       REFERENCE_LIST_SYNTAX_TYPE_PLAIN_TEXT_STRING
       REFERENCE_LIST_SYNTAX_TYPE_REGEX
       REFERENCE_LIST_SYNTAX_TYPE_CIDR

diff --git a/mmv1/templates/terraform/examples/chronicle_referencelist_basic.tf.tmpl b/mmv1/templates/terraform/examples/chronicle_referencelist_basic.tf.tmpl
@@ -3,9 +3,9 @@ resource "google_chronicle_reference_list" "{{$.PrimaryResourceId}}" {
  location = "us"
  instance = "{{index $.TestEnvVars "chronicle_id"}}"
  reference_list_id = "{{index $.Vars "reference_list_id"}}"
- description = "{{index $.Vars "description"}}"
+ description = "referencelist-description"
  entries {
-  value = "{{index $.Vars "reference_list_entry_value"}}"
+  value = "referencelist-entry-value"
  }
  syntax_type = "REFERENCE_LIST_SYNTAX_TYPE_PLAIN_TEXT_STRING"
 }
diff --git a/mmv1/third_party/terraform/services/chronicle/resource_chronicle_reference_list_test.go.tmpl b/mmv1/third_party/terraform/services/chronicle/resource_chronicle_reference_list_test.go.tmpl
@@ -52,9 +52,9 @@ resource "google_chronicle_reference_list" "example" {
  location = "us"
  instance = "%{chronicle_id}"
  reference_list_id = "tf_test_reference_list_id%{random_suffix}"
- description = "tf-test-referencelist-description%{random_suffix}"
+ description = "referencelist-description"
  entries {
-  value = "tf-test-referencelist-entry-value%{random_suffix}"
+  value = "referencelist-entry-value"
  }
  syntax_type = "REFERENCE_LIST_SYNTAX_TYPE_PLAIN_TEXT_STRING"
 }
@@ -68,9 +68,9 @@ resource "google_chronicle_reference_list" "example" {
  location = "us"
  instance = "%{chronicle_id}"
  reference_list_id = "tf_test_reference_list_id%{random_suffix}"
- description = "tf-test-referencelist-description-updated%{random_suffix}"
+ description = "referencelist-description-updated"
  entries {
-  value = "tf-test-referencelist-entry-value-updated%{random_suffix}"
+  value = "referencelist-entry-value-updated"
  }
  syntax_type = "REFERENCE_LIST_SYNTAX_TYPE_REGEX"
 }