Fix the index of boundary error for metadata field (#10417)

GoogleCloudPlatform · Apr 11, 2024 · 5e2e040 · 5e2e040
1 parent ffaae41
commit 5e2e040
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/mmv1/third_party/terraform/tpgresource/annotations.go b/mmv1/third_party/terraform/tpgresource/annotations.go
@@ -58,7 +58,8 @@ func SetMetadataAnnotationsDiff(_ context.Context, d *schema.ResourceDiff, meta
 	// "effective_annotations" cannot be set directly due to a bug that SetNew doesn't work on nested fields
 	// in terraform sdk.
 	// https://github.com/hashicorp/terraform-plugin-sdk/issues/459
-	if !d.GetRawPlan().GetAttr("metadata").AsValueSlice()[0].GetAttr("annotations").IsWhollyKnown() {
+	values := d.GetRawPlan().GetAttr("metadata").AsValueSlice()
+	if len(values) > 0 && !values[0].GetAttr("annotations").IsWhollyKnown() {
 		return nil
 	}
 

diff --git a/mmv1/third_party/terraform/tpgresource/labels.go b/mmv1/third_party/terraform/tpgresource/labels.go
@@ -143,7 +143,8 @@ func SetMetadataLabelsDiff(_ context.Context, d *schema.ResourceDiff, meta inter
 	// "terraform_labels" and "effective_labels" cannot be set directly due to a bug that SetNew doesn't work on nested fields
 	// in terraform sdk.
 	// https://github.com/hashicorp/terraform-plugin-sdk/issues/459
-	if !d.GetRawPlan().GetAttr("metadata").AsValueSlice()[0].GetAttr("labels").IsWhollyKnown() {
+	values := d.GetRawPlan().GetAttr("metadata").AsValueSlice()
+	if len(values) > 0 && !values[0].GetAttr("labels").IsWhollyKnown() {
 		return nil
 	}