Skip to content

Commit

Permalink
Rework PR to mark fields deprecated first and use secret for key_uri.
Browse files Browse the repository at this point in the history
  • Loading branch information
tdbhacks committed Feb 23, 2024
1 parent 25ea922 commit b514152
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
16 changes: 16 additions & 0 deletions mmv1/products/kms/CryptoKeyVersion.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,22 @@ properties:
description: |
Google partition certificate chain corresponding to the attestation.
output: true
- !ruby/object:Api::Type::NestedObject
name: 'externalProtectionLevelOptions'
description: |
ExternalProtectionLevelOptions stores a group of additional fields for configuring a CryptoKeyVersion that are specific to the EXTERNAL protection level and EXTERNAL_VPC protection levels.
deprecation_message: >-
`externalProtectionLevelOptions` is being un-nested from the `attestation` field.
Please use the top level `externalProtectionLevelOptions` field instead.
properties:
- !ruby/object:Api::Type::String
name: 'externalKeyUri'
description: |
The URI for an external resource that this CryptoKeyVersion represents.
- !ruby/object:Api::Type::String
name: 'ekmConnectionKeyPath'
description: |
The path to the external key material on the EKM when using EkmConnection e.g., "v0/my/key". Set this field instead of externalKeyUri when using an EkmConnection.
- !ruby/object:Api::Type::NestedObject
name: 'externalProtectionLevelOptions'
description: |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -951,7 +951,7 @@ resource "google_kms_crypto_key" "crypto_key" {
resource "google_kms_crypto_key_version" "crypto_key_version" {
crypto_key = google_kms_crypto_key.crypto_key.id
external_protection_level_options {
external_key_uri = "https://ekms.example/key_path"
external_key_uri = "projects/315636579862/secrets/external-uri/versions/latest"
}
}
`, projectId, projectId, projectOrg, projectBillingAccount, keyRingName, cryptoKeyName)
Expand Down

0 comments on commit b514152

Please sign in to comment.