Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go rewrite - fix some more documentation diffs #10834

Merged
merged 2 commits into from
May 30, 2024

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented May 30, 2024

Release Note Template for Downstream PRs (will be copied)


@c2thorn c2thorn requested a review from zli82016 May 30, 2024 12:44
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@c2thorn c2thorn merged commit 78c5509 into GoogleCloudPlatform:main May 30, 2024
11 checks passed
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 24, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants