memorystore open api #11463
Merged
memorystore open api #11463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
Thanks for checking in. I'm still developing but I don't mind any initial feedback. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_memorystore_instance" "primary" {
deletion_protection_enabled = # value needed
engine_configs = # value needed
engine_version = # value needed
instance_id = # value needed
labels = # value needed
location = # value needed
persistence_config {
aof_config {
append_fsync = # value needed
}
mode = # value needed
rdb_config {
rdb_snapshot_period = # value needed
rdb_snapshot_start_time = # value needed
}
}
psc_auto_connections {
project_id = # value needed
}
zone_distribution_config {
zone = # value needed
}
}
|
Tests analyticsTotal tests: 3900 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_memorystore_instance" "primary" {
engine_version = # value needed
labels = # value needed
persistence_config {
aof_config {
append_fsync = # value needed
}
mode = # value needed
rdb_config {
rdb_snapshot_period = # value needed
rdb_snapshot_start_time = # value needed
}
}
zone_distribution_config {
zone = # value needed
}
}
|
Tests analyticsTotal tests: 3907 Click here to see the affected service packages
Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
|
|
@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
roaks3
reviewed
Aug 23, 2024
| min_version: beta | ||
| vars: | ||
| instance_name: "ha-instance" | ||
| policy_name: "mypolicy" |
There was a problem hiding this comment.
These variables should all include a hyphen, like my-policy, so that our generator adds the tf-test prefix behind the scenes, and these resources can be cleaned up if the test fails
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_memorystore_instance" "primary" {
desired_psc_auto_connections = # value needed
engine_version = # value needed
labels = # value needed
persistence_config {
aof_config {
append_fsync = # value needed
}
mode = # value needed
rdb_config {
rdb_snapshot_period = # value needed
rdb_snapshot_start_time = # value needed
}
}
zone_distribution_config {
zone = # value needed
}
}
|
Tests analyticsTotal tests: 3910 Click here to see the affected service packages
Action takenFound 3488 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
himanikh
commented
Aug 23, 2024
| @@ -496,6 +496,11 @@ var ServicesListBeta = mapOf( | |||
| "displayName" to "Memcache", | |||
| "path" to "./google-beta/services/memcache" | |||
| ), | |||
| "memorystore" to mapOf( | |||
There was a problem hiding this comment.
I see the failure: https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/10532606319/job/29187084684?pr=11463
This is not a GA service yet. Do I need to add it to mmv1/third_party/terraform/.teamcity/components/inputs/services_ga.kt ?
There was a problem hiding this comment.
I don't think you need to. I believe these are used for our nightly tests of the corresponding provider.
|
drive-by /gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_memorystore_instance" "primary" {
desired_psc_auto_connections = # value needed
engine_version = # value needed
labels = # value needed
persistence_config {
aof_config {
append_fsync = # value needed
}
mode = # value needed
rdb_config {
rdb_snapshot_period = # value needed
rdb_snapshot_start_time = # value needed
}
}
zone_distribution_config {
zone = # value needed
}
}
|
Tests analyticsTotal tests: 3911 Click here to see the affected service packages
Action takenFound 3489 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label |
roaks3
reviewed
Sep 4, 2024
| @@ -496,6 +496,11 @@ var ServicesListBeta = mapOf( | |||
| "displayName" to "Memcache", | |||
| "path" to "./google-beta/services/memcache" | |||
| ), | |||
| "memorystore" to mapOf( | |||
There was a problem hiding this comment.
I don't think you need to. I believe these are used for our nightly tests of the corresponding provider.
roaks3
reviewed
Sep 5, 2024
Autogen version: 91f60bf |
|
Re: #11463 (comment) TeamCity Services Diff Check / teamcity-services-diff-check (pull_request) fails if I don't add the service to teamcity config. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 3965 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
roaks3
reviewed
Sep 5, 2024
mmv1/templates/terraform/examples/memorystore_instance_basic.tf.erb
Outdated
Show resolved
Hide resolved
mmv1/templates/terraform/examples/memorystore_instance_basic.tf.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/memorystore/resource_memorystore_instance_test.go.erb
Show resolved
Hide resolved
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 3967 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
|
roaks3
approved these changes
Sep 6, 2024
This was referenced Sep 6, 2024
entertvl
pushed a commit
to entertvl/magic-modules
that referenced
this pull request
Sep 9, 2024
iyabchen
pushed a commit
to iyabchen/magic-modules
that referenced
this pull request
Sep 14, 2024
abd-goog
pushed a commit
to abd-goog/magic-modules
that referenced
this pull request
Sep 23, 2024
niharika-98
pushed a commit
to niharika-98/magic-modules
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new service Memorystore
Release Note Template for Downstream PRs (will be copied)