Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new resource for Backfill Pipeline Jobs for Healthcare Data Engine #11677

Merged
merged 22 commits into from
Sep 19, 2024

Conversation

ashwinsshetty
Copy link
Contributor

@ashwinsshetty ashwinsshetty commented Sep 11, 2024

Add support for creating Whistle Mapping, Reconciliation and Backfill Pipeline for Healthcare Data Engine

Link: https://cloud.google.com/healthcare-api/healthcare-data-engine/docs/reference/rest/v1/projects.locations.datasets.pipelineJobs/create

Fixes hashicorp/terraform-provider-google#19412

`google_healthcare_pipeline_job`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 2256 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 2256 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 604 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 264 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_healthcare_pipeline_job (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_healthcare_pipeline_job" "primary" {
  labels = # value needed
  mapping_pipeline_job {
    cloud_spanner_source {
      change_stream = # value needed
      database_path = # value needed
      description   = # value needed
    }
    fhir_store_destination = # value needed
    fhir_streaming_source {
      description = # value needed
      fhir_store  = # value needed
    }
    mapping_config {
      data_mapper_config_source {
        gcs {
          uri_prefix = # value needed
        }
        mapping            = # value needed
        mapping_version_id = # value needed
        parameter_key      = # value needed
      }
      description = # value needed
      whistle_config_source {
        import_uri_prefix = # value needed
        uri               = # value needed
      }
    }
    reconciliation_destination = # value needed
  }
  reconciliation_pipeline_job {
    merge_config {
      data_mapper_config_source {
        gcs {
          uri_prefix = # value needed
        }
        mapping            = # value needed
        mapping_version_id = # value needed
        parameter_key      = # value needed
      }
      description = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 40
Passed tests: 38
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • healthcare

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
  • TestAccHealthcarePipelineJob_healthcarePipelineJobReconciliationExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample[Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobReconciliationExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 2393 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 2393 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 604 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 416 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_healthcare_pipeline_job (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_healthcare_pipeline_job" "primary" {
  labels = # value needed
  mapping_pipeline_job {
    cloud_spanner_source {
      change_stream = # value needed
      database_path = # value needed
      description   = # value needed
    }
    fhir_streaming_source {
      description = # value needed
    }
    mapping_config {
      data_mapper_config_source {
        gcs {
          uri_prefix = # value needed
        }
        mapping            = # value needed
        mapping_version_id = # value needed
        parameter_key      = # value needed
      }
      description = # value needed
    }
    reconciliation_destination = # value needed
  }
  reconciliation_pipeline_job {
    merge_config {
      data_mapper_config_source {
        gcs {
          uri_prefix = # value needed
        }
        mapping            = # value needed
        mapping_version_id = # value needed
        parameter_key      = # value needed
      }
      description = # value needed
    }
  }
}

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 2393 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 2393 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 604 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 416 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_healthcare_pipeline_job (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_healthcare_pipeline_job" "primary" {
  labels = # value needed
  mapping_pipeline_job {
    cloud_spanner_source {
      change_stream = # value needed
      database_path = # value needed
      description   = # value needed
    }
    fhir_streaming_source {
      description = # value needed
    }
    mapping_config {
      data_mapper_config_source {
        gcs {
          uri_prefix = # value needed
        }
        mapping            = # value needed
        mapping_version_id = # value needed
        parameter_key      = # value needed
      }
      description = # value needed
    }
    reconciliation_destination = # value needed
  }
  reconciliation_pipeline_job {
    merge_config {
      data_mapper_config_source {
        gcs {
          uri_prefix = # value needed
        }
        mapping            = # value needed
        mapping_version_id = # value needed
        parameter_key      = # value needed
      }
      description = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 41
Passed tests: 38
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • healthcare

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
  • TestAccHealthcarePipelineJob_healthcarePipelineJobReconciliationExample
  • TestAccHealthcarePipelineJob_healthcarePipelineJobWhistleMappingExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample[Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobReconciliationExample[Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobWhistleMappingExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 41
Passed tests: 38
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • healthcare

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
  • TestAccHealthcarePipelineJob_healthcarePipelineJobReconciliationExample
  • TestAccHealthcarePipelineJob_healthcarePipelineJobWhistleMappingExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample[Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobReconciliationExample[Error message] [Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobWhistleMappingExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@rileykarson
Copy link
Member

@trodge can you pick up review? I got preempted by some other work.

@trodge trodge self-assigned this Sep 17, 2024
@trodge
Copy link
Contributor

trodge commented Sep 17, 2024

Thanks so much for the contribution. Would it be possible to add the fields from the missing test report to an example or else add a test that includes them?

Copy link
Contributor

@trodge trodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but would like to see more complete test coverage if possible.

@github-actions github-actions bot requested a review from trodge September 18, 2024 04:12
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 2264 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 2264 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 552 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 416 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_healthcare_pipeline_job (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_healthcare_pipeline_job" "primary" {
  labels = # value needed
  mapping_pipeline_job {
    fhir_streaming_source {
      description = # value needed
    }
    mapping_config {
      data_mapper_config_source {
        gcs {
          uri_prefix = # value needed
        }
        mapping            = # value needed
        mapping_version_id = # value needed
        parameter_key      = # value needed
      }
      description = # value needed
    }
    reconciliation_destination = # value needed
  }
  reconciliation_pipeline_job {
    merge_config {
      data_mapper_config_source {
        gcs {
          uri_prefix = # value needed
        }
        mapping            = # value needed
        mapping_version_id = # value needed
        parameter_key      = # value needed
      }
      description = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 43
Passed tests: 43
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • healthcare

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 2024 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 2024 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 388 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 596 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 44
Passed tests: 41
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • healthcare

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccHealthcarePipelineJob_healthcarePipelineJobMappingReconDestExample
  • TestAccHealthcarePipelineJob_healthcarePipelineJobReconciliationExample
  • TestAccHealthcarePipelineJob_healthcarePipelineJobWhistleMappingExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccHealthcarePipelineJob_healthcarePipelineJobMappingReconDestExample[Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobReconciliationExample[Debug log]
TestAccHealthcarePipelineJob_healthcarePipelineJobWhistleMappingExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@ashwinsshetty
Copy link
Contributor Author

Overall LGTM, but would like to see more complete test coverage if possible.

Thanks @trodge for the review. I have added additional test coverage. Could you please take a look and let me know if this is good to merge.

@ashwinsshetty
Copy link
Contributor Author

Thanks @trodge for the review and approval. Do we need anything else to MERGE this.

@github-actions github-actions bot requested a review from trodge September 19, 2024 14:01
@trodge trodge merged commit 1902bac into GoogleCloudPlatform:main Sep 19, 2024
13 checks passed
abd-goog pushed a commit to abd-goog/magic-modules that referenced this pull request Sep 23, 2024
@melinath melinath changed the title Add new resource for creating Whistle Mapping, Reconciliation and Backfill Pipeline Jobs for Healthcare Data Engine Add new resource for Backfill Pipeline Jobs for Healthcare Data Engine Sep 30, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
Philip-Jonany pushed a commit to Philip-Jonany/magic-modules that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for creating Whistle Mapping, Reconciliation and Backfill Pipeline for Healthcare Data Engine
4 participants