-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new resource for Backfill Pipeline Jobs for Healthcare Data Engine #11677
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_healthcare_pipeline_job" "primary" {
labels = # value needed
mapping_pipeline_job {
cloud_spanner_source {
change_stream = # value needed
database_path = # value needed
description = # value needed
}
fhir_store_destination = # value needed
fhir_streaming_source {
description = # value needed
fhir_store = # value needed
}
mapping_config {
data_mapper_config_source {
gcs {
uri_prefix = # value needed
}
mapping = # value needed
mapping_version_id = # value needed
parameter_key = # value needed
}
description = # value needed
whistle_config_source {
import_uri_prefix = # value needed
uri = # value needed
}
}
reconciliation_destination = # value needed
}
reconciliation_pipeline_job {
merge_config {
data_mapper_config_source {
gcs {
uri_prefix = # value needed
}
mapping = # value needed
mapping_version_id = # value needed
parameter_key = # value needed
}
description = # value needed
}
}
}
|
Tests analyticsTotal tests: 40 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_healthcare_pipeline_job" "primary" {
labels = # value needed
mapping_pipeline_job {
cloud_spanner_source {
change_stream = # value needed
database_path = # value needed
description = # value needed
}
fhir_streaming_source {
description = # value needed
}
mapping_config {
data_mapper_config_source {
gcs {
uri_prefix = # value needed
}
mapping = # value needed
mapping_version_id = # value needed
parameter_key = # value needed
}
description = # value needed
}
reconciliation_destination = # value needed
}
reconciliation_pipeline_job {
merge_config {
data_mapper_config_source {
gcs {
uri_prefix = # value needed
}
mapping = # value needed
mapping_version_id = # value needed
parameter_key = # value needed
}
description = # value needed
}
}
}
|
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_healthcare_pipeline_job" "primary" {
labels = # value needed
mapping_pipeline_job {
cloud_spanner_source {
change_stream = # value needed
database_path = # value needed
description = # value needed
}
fhir_streaming_source {
description = # value needed
}
mapping_config {
data_mapper_config_source {
gcs {
uri_prefix = # value needed
}
mapping = # value needed
mapping_version_id = # value needed
parameter_key = # value needed
}
description = # value needed
}
reconciliation_destination = # value needed
}
reconciliation_pipeline_job {
merge_config {
data_mapper_config_source {
gcs {
uri_prefix = # value needed
}
mapping = # value needed
mapping_version_id = # value needed
parameter_key = # value needed
}
description = # value needed
}
}
}
|
Tests analyticsTotal tests: 41 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Tests analyticsTotal tests: 41 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
@trodge can you pick up review? I got preempted by some other work. |
Thanks so much for the contribution. Would it be possible to add the fields from the missing test report to an example or else add a test that includes them? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, but would like to see more complete test coverage if possible.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_healthcare_pipeline_job" "primary" {
labels = # value needed
mapping_pipeline_job {
fhir_streaming_source {
description = # value needed
}
mapping_config {
data_mapper_config_source {
gcs {
uri_prefix = # value needed
}
mapping = # value needed
mapping_version_id = # value needed
parameter_key = # value needed
}
description = # value needed
}
reconciliation_destination = # value needed
}
reconciliation_pipeline_job {
merge_config {
data_mapper_config_source {
gcs {
uri_prefix = # value needed
}
mapping = # value needed
mapping_version_id = # value needed
parameter_key = # value needed
}
description = # value needed
}
}
}
|
Tests analyticsTotal tests: 43 Click here to see the affected service packages
View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 44 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Thanks @trodge for the review. I have added additional test coverage. Could you please take a look and let me know if this is good to merge. |
Thanks @trodge for the review and approval. Do we need anything else to MERGE this. |
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11677)
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11677)
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11677)
Add support for creating Whistle Mapping, Reconciliation and Backfill Pipeline for Healthcare Data Engine
Link: https://cloud.google.com/healthcare-api/healthcare-data-engine/docs/reference/rest/v1/projects.locations.datasets.pipelineJobs/create
Fixes hashicorp/terraform-provider-google#19412