container: refactor `node_config` node pool update #11826

wyardley · 2024-09-26T05:59:37Z

This sets the stage for consolidating the logic for updating nodepools between the container_cluster and container_node_pool resources, by creating a new nodePoolNodeConfigUpdate() function.

Part of hashicorp/terraform-provider-google#19225

Release Note Template for Downstream PRs (will be copied)

github-actions · 2024-09-26T20:39:24Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

wyardley · 2024-09-26T20:52:16Z

mmv1/third_party/terraform/services/container/node_config.go.tmpl

+					nodePoolInfo.project,
+					nodePoolInfo.location,
+					"updating GKE node pool disk_size_gb/disk_type/machine_type/storage_pools", userAgent,
+					timeout)


A lot of opportunity to DRY up these parts with a function at some point too, but trying to keep it pretty self-contained here for now.

modular-magician · 2024-09-30T20:33:26Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 532 insertions(+), 509 deletions(-))
google-beta provider: Diff ( 2 files changed, 531 insertions(+), 509 deletions(-))

modular-magician · 2024-09-30T20:42:00Z

Tests analytics

Total tests: 212
Passed tests: 199
Skipped tests: 13
Affected tests: 0

Click here to see the affected service packages

container

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

github-actions · 2024-10-01T09:41:53Z

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2024-10-03T09:41:32Z

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2024-10-10T09:42:14Z

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

This sets the stage for consolidating the logic for updating nodepools between the `container_cluster` and `container_node_pool` resources, by creating a new `nodePoolNodeConfigUpdate()` function. Part of hashicorp/terraform-provider-google#19225

NickElliot

sorry for the delays! Didn't realize the scope of this specific change in the larger issue was deceptively small and kept pushing back the review to put more time into it.

LGTM! will wait on this last build

wyardley · 2024-10-15T21:31:05Z

Hah, yes, the actual change is one line plus moving a big block of code. It should set the stage for sharing the code with the default node pool update. Can check out the version before the second commit if you want to see which you prefer.

modular-magician · 2024-10-15T21:35:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 535 insertions(+), 512 deletions(-))
google-beta provider: Diff ( 2 files changed, 534 insertions(+), 512 deletions(-))

modular-magician · 2024-10-15T21:42:30Z

Tests analytics

Total tests: 212
Passed tests: 199
Skipped tests: 13
Affected tests: 0

Click here to see the affected service packages

container

🟢 All tests passed!

View the build log

This resolves an issue where many subfields of `node_config` in a cluster (which affects the default node-pool "default-pool" when `remove_default_node_pool` is not set to `false`) don't support updates properly. Fixes #19225 Follow up to GoogleCloudPlatform#11826

This resolves an issue where many subfields of `node_config` in a cluster (which affects the default node-pool "default-pool" when `remove_default_node_pool` is not set to `false`) don't support updates properly. Fixes hashicorp/terraform-provider-google#19225 Followup to GoogleCloudPlatform#11826 where the code used by the regular node pool update code was broken out.

…rm#11826)

This resolves an issue where many subfields of `node_config` in a cluster (which affects the default node-pool "default-pool" when `remove_default_node_pool` is not set to `false`) don't support updates properly. Fixes hashicorp/terraform-provider-google#19225 Followup to GoogleCloudPlatform#11826 where the code used by the regular node pool update code was broken out.

…rm#11826)

This resolves an issue where many subfields of `node_config` in a cluster (which affects the default node-pool "default-pool" when `remove_default_node_pool` is not set to `false`) don't support updates properly. Fixes hashicorp/terraform-provider-google#19225 Followup to GoogleCloudPlatform#11826 where the code used by the regular node pool update code was broken out.

…rm#11826)

This resolves an issue where many subfields of `node_config` in a cluster (which affects the default node-pool "default-pool" when `remove_default_node_pool` is not set to `false`) don't support updates properly. Fixes hashicorp/terraform-provider-google#19225 Followup to GoogleCloudPlatform#11826 where the code used by the regular node pool update code was broken out.

…rm#11826)

This resolves an issue where many subfields of `node_config` in a cluster (which affects the default node-pool "default-pool" when `remove_default_node_pool` is not set to `false`) don't support updates properly. Fixes hashicorp/terraform-provider-google#19225 Followup to GoogleCloudPlatform#11826 where the code used by the regular node pool update code was broken out.

…rm#11826)

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 26, 2024

This was referenced Sep 26, 2024

google_container_cluster.node_config subfields can't be updated in-place hashicorp/terraform-provider-google#19225

Closed

container: fix storage pool resource names in test #11832

Merged

wyardley force-pushed the wyardley/node_config_update/19225_partial branch from 5486b3d to 8e3c116 Compare September 26, 2024 20:37

wyardley marked this pull request as ready for review September 26, 2024 20:38

github-actions bot requested a review from NickElliot September 26, 2024 20:39

wyardley commented Sep 26, 2024

View reviewed changes

wyardley force-pushed the wyardley/node_config_update/19225_partial branch from 8e3c116 to d467fd7 Compare September 26, 2024 22:00

wyardley changed the title ~~refactor: move node_config node pool update~~ container: refactor node_config node pool update Sep 27, 2024

modular-magician added service/container and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Sep 30, 2024

wyardley added 2 commits October 15, 2024 11:14

adjust scope and function args

2291e12

wyardley force-pushed the wyardley/node_config_update/19225_partial branch from d467fd7 to 2291e12 Compare October 15, 2024 18:14

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 15, 2024

NickElliot approved these changes Oct 15, 2024

View reviewed changes

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 15, 2024

github-actions bot requested a review from NickElliot October 15, 2024 21:31

NickElliot merged commit 6b80c16 into GoogleCloudPlatform:main Oct 15, 2024
10 checks passed

This was referenced Oct 15, 2024

container: refactor node_config node pool update hashicorp/terraform-provider-google-beta#8417

Merged

container: refactor node_config node pool update hashicorp/terraform-provider-google#19868

Merged

wyardley deleted the wyardley/node_config_update/19225_partial branch October 15, 2024 21:49

modular-magician mentioned this pull request Oct 15, 2024

container: refactor node_config node pool update GoogleCloudPlatform/terraform-google-conversion#2941

Merged

wyardley mentioned this pull request Oct 16, 2024

container: fix missing updates for google_container_cluster.node_config subfields #12014

Merged

gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024

container: refactor node_config node pool update (GoogleCloudPlatfo…

be0ed92

…rm#11826)

varshatumburu pushed a commit to varshatumburu/magic-modules that referenced this pull request Oct 19, 2024

container: refactor node_config node pool update (GoogleCloudPlatfo…

ea798ae

…rm#11826)

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024

container: refactor node_config node pool update (GoogleCloudPlatfo…

98597e1

…rm#11826)

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024

container: refactor node_config node pool update (GoogleCloudPlatfo…

27bb12d

…rm#11826)

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024

container: refactor node_config node pool update (GoogleCloudPlatfo…

94d3c6d

…rm#11826)

akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024

container: refactor node_config node pool update (GoogleCloudPlatfo…

d9e3cd9

…rm#11826)

amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024

container: refactor node_config node pool update (GoogleCloudPlatfo…

4186a62

…rm#11826)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

container: refactor `node_config` node pool update #11826

container: refactor `node_config` node pool update #11826

wyardley commented Sep 26, 2024

github-actions bot commented Sep 26, 2024

wyardley Sep 26, 2024

modular-magician commented Sep 30, 2024

modular-magician commented Sep 30, 2024

github-actions bot commented Oct 1, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 10, 2024

NickElliot left a comment •

edited

Loading

wyardley commented Oct 15, 2024

modular-magician commented Oct 15, 2024

modular-magician commented Oct 15, 2024

container: refactor node_config node pool update #11826

container: refactor node_config node pool update #11826

Conversation

wyardley commented Sep 26, 2024

github-actions bot commented Sep 26, 2024

wyardley Sep 26, 2024

Choose a reason for hiding this comment

modular-magician commented Sep 30, 2024

Diff report

modular-magician commented Sep 30, 2024

Tests analytics

github-actions bot commented Oct 1, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 10, 2024

NickElliot left a comment • edited Loading

Choose a reason for hiding this comment

wyardley commented Oct 15, 2024

modular-magician commented Oct 15, 2024

Diff report

modular-magician commented Oct 15, 2024

Tests analytics

container: refactor `node_config` node pool update #11826

container: refactor `node_config` node pool update #11826

NickElliot left a comment •

edited

Loading