Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add increased length & Unicode tagkey and tagvalue shortname support #11827

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

abd-goog
Copy link
Member

@abd-goog abd-goog commented Sep 26, 2024

TagKeys and TagValues already support increased length tagkey and tagValue shortnames. They now also support UTF-8 encoded Unicode characters. Making necessary changes for Terraform to bring parity with other clients such as gcloud.
Ref: https://cloud.google.com/resource-manager/docs/tags/tags-creating-and-managing#creating_tag
Part of b/368039508

Release Note Template for Downstream PRs (will be copied)

tags: increased maximum accepted input length for the `short_name` field in `google_tags_tag_key` and `google_tags_tag_value` resources

@abd-goog abd-goog marked this pull request as ready for review September 26, 2024 06:51
@github-actions github-actions bot requested a review from NickElliot September 26, 2024 06:52
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 10
Passed tests: 10
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • tags

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Copy link

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor changes then LGTM

mmv1/products/tags/TagKey.yaml Outdated Show resolved Hide resolved
mmv1/products/tags/TagValue.yaml Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a review from NickElliot October 1, 2024 05:39
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 4 files changed, 6 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 10
Passed tests: 9
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • tags

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccTags

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 10
Passed tests: 9
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • tags

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccTags

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccTags[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccTags[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickElliot NickElliot merged commit faf2801 into GoogleCloudPlatform:main Oct 1, 2024
12 checks passed
karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 4, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
trodge pushed a commit to trodge/magic-modules that referenced this pull request Oct 10, 2024
karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 11, 2024
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants