-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add increased length & Unicode tagkey and tagvalue shortname support #11827
Add increased length & Unicode tagkey and tagvalue shortname support #11827
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 10 Click here to see the affected service packages
View the build log |
@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two minor changes then LGTM
Co-authored-by: Nick Elliot <[email protected]>
Co-authored-by: Nick Elliot <[email protected]>
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 10 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
1 similar comment
Tests analyticsTotal tests: 10 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…oogleCloudPlatform#11827) Co-authored-by: Nick Elliot <[email protected]>
…oogleCloudPlatform#11827) Co-authored-by: Nick Elliot <[email protected]>
…oogleCloudPlatform#11827) Co-authored-by: Nick Elliot <[email protected]>
…oogleCloudPlatform#11827) Co-authored-by: Nick Elliot <[email protected]>
…oogleCloudPlatform#11827) Co-authored-by: Nick Elliot <[email protected]>
…oogleCloudPlatform#11827) Co-authored-by: Nick Elliot <[email protected]>
…oogleCloudPlatform#11827) Co-authored-by: Nick Elliot <[email protected]>
…oogleCloudPlatform#11827) Co-authored-by: Nick Elliot <[email protected]>
…oogleCloudPlatform#11827) Co-authored-by: Nick Elliot <[email protected]>
TagKeys and TagValues already support increased length tagkey and tagValue shortnames. They now also support UTF-8 encoded Unicode characters. Making necessary changes for Terraform to bring parity with other clients such as gcloud.
Ref: https://cloud.google.com/resource-manager/docs/tags/tags-creating-and-managing#creating_tag
Part of b/368039508
Release Note Template for Downstream PRs (will be copied)