Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ephemeral resource support #11843

Conversation

SarahFrench
Copy link
Contributor

@SarahFrench SarahFrench commented Sep 26, 2024

Add basic support for ephemeral resources

  • Add dependency on branch in https://github.com/hashicorp/terraform-plugin-framework that contains necessary features
    • go get github.com/hashicorp/terraform-plugin-framework@fe2b7dbbdad8ac4e45efee7e4a9eb1fd08003fcf
      • Need to use a commit due to the branch name containing a forward slash
    • We will change this before merging the overall feature branch, but using this during development is fine!
  • Implemented this interface
  • Currently there are no test environments (PR automation, TeamCity) that can utilise ephemeral values

Merging this PR into the feature branch will enable working on multiple ephemeral resources in separate PRs at once.

Release Note Template for Downstream PRs (will be copied)


@SarahFrench SarahFrench requested a review from BBBmau September 26, 2024 20:49
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 16 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 16 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4100
Passed tests: 3687
Skipped tests: 413
Affected tests: 0

Click here to see the affected service packages

All service packages are affected

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Copy link

github-actions bot commented Oct 1, 2024

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

github-actions bot commented Oct 3, 2024

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Collaborator

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for including _ provider.ProviderWithEphemeralResources = &FrameworkProvider{}!

@SarahFrench
Copy link
Contributor Author

Thanks! This PR should make it possible to work on different PRs in parallel to implement different ephemeral resources

@SarahFrench SarahFrench merged commit c607798 into GoogleCloudPlatform:FEATURE-BRANCH-ephemeral-resource Oct 3, 2024
14 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants