Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the promotion of Port Mapping NEGs from GA to Beta #11854

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

Cheriit
Copy link
Contributor

@Cheriit Cheriit commented Sep 27, 2024

Revert the PR #11771

Release Note Template for Downstream PRs (will be copied)

compute: promoted `client_destination_port` and `instance` fields in `google_compute_region_network_endpoint` resource to GA (revert)

@github-actions github-actions bot requested a review from melinath September 27, 2024 12:57
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 13 insertions(+), 221 deletions(-))
google-beta provider: Diff ( 5 files changed, 22 insertions(+), 5 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field client_destination_port within resource google_compute_region_network_endpoint was either removed or renamed - reference
  • Field instance within resource google_compute_region_network_endpoint was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@melinath melinath added the override-breaking-change Allows a potential breaking change to be merged label Sep 30, 2024
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1017
Passed tests: 943
Skipped tests: 74
Affected tests: 0

Click here to see the affected service packages
  • compute

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@ScottSuarez ScottSuarez merged commit 2d34af8 into GoogleCloudPlatform:main Sep 30, 2024
12 of 13 checks passed
anavada pushed a commit to anavada/magic-modules that referenced this pull request Sep 30, 2024
karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 4, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
trodge pushed a commit to trodge/magic-modules that referenced this pull request Oct 10, 2024
karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 11, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
Philip-Jonany pushed a commit to Philip-Jonany/magic-modules that referenced this pull request Nov 4, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
override-breaking-change Allows a potential breaking change to be merged service/compute-networking-neg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants