-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched to emoji for color-based emphasis #11861
Conversation
Also updated template formatting tests to be less prescriptive about the exact formatting of the returned message.
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
Tests analyticsTotal tests: 10 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
This comment was marked as outdated.
This comment was marked as outdated.
This reverts commit 587dcad.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution!
(Personal preference: I would probably vote for just the preceding emoji, instead of one before AND after)
Yeah, it's a bit much - made that change in 7612963 and added a space after the emoji. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
Also updated template formatting tests to be less prescriptive about the exact formatting of the returned message.
Fixed hashicorp/terraform-provider-google#19301
Release Note Template for Downstream PRs (will be copied)