Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to emoji for color-based emphasis #11861

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

melinath
Copy link
Member

@melinath melinath commented Sep 27, 2024

Also updated template formatting tests to be less prescriptive about the exact formatting of the returned message.

Fixed hashicorp/terraform-provider-google#19301

Release Note Template for Downstream PRs (will be copied)


Also updated template formatting tests to be less prescriptive about the exact formatting of the returned message.
@melinath melinath requested a review from roaks3 September 27, 2024 19:02
@modular-magician

This comment was marked as outdated.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician

This comment was marked as outdated.

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 10
Passed tests: 9
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • tags

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccTags

Get to know how VCR tests work

@modular-magician

This comment was marked as outdated.

@modular-magician
Copy link
Collaborator

🟢Tests passed during RECORDING mode:🟢
TestAccTags[Debug log]

🟢No issues found for passed tests after REPLAYING rerun.🟢


🟢All tests passed!🟢

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution!

(Personal preference: I would probably vote for just the preceding emoji, instead of one before AND after)

@melinath
Copy link
Member Author

(Personal preference: I would probably vote for just the preceding emoji, instead of one before AND after)

Yeah, it's a bit much - made that change in 7612963 and added a space after the emoji.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@melinath melinath merged commit b750180 into GoogleCloudPlatform:main Sep 30, 2024
8 of 10 checks passed
@melinath melinath deleted the tpg-19301 branch September 30, 2024 22:06
anavada pushed a commit to anavada/magic-modules that referenced this pull request Sep 30, 2024
karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 4, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
trodge pushed a commit to trodge/magic-modules that referenced this pull request Oct 10, 2024
karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 11, 2024
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix intermittent formatting issue with VCR test reports
3 participants