Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "upgrade dcl version to v1.73.0 (#11804)" #11862

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

roaks3
Copy link
Contributor

@roaks3 roaks3 commented Sep 27, 2024

This reverts commit 0e7c75a.

Release Note Template for Downstream PRs (will be copied)


@roaks3 roaks3 requested a review from NickElliot September 27, 2024 20:08
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 3 insertions(+), 132 deletions(-))
google-beta provider: Diff ( 7 files changed, 3 insertions(+), 146 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field kubelet_config.cpu_cfs_quota_period within resource google_container_aws_node_pool was either removed or renamed - reference
  • Field kubelet_config.cpu_cfs_quota within resource google_container_aws_node_pool was either removed or renamed - reference
  • Field kubelet_config.cpu_manager_policy within resource google_container_aws_node_pool was either removed or renamed - reference
  • Field kubelet_config.pod_pids_limit within resource google_container_aws_node_pool was either removed or renamed - reference
  • Field kubelet_config within resource google_container_aws_node_pool was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4105
Passed tests: 3690
Skipped tests: 413
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerAwsNodePool_BasicHandWritten
  • TestAccContainerAwsNodePool_BetaBasicHandWritten

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BasicHandWritten[Debug log]
TestAccContainerAwsNodePool_BetaBasicHandWritten[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@roaks3 roaks3 merged commit abefe83 into main Sep 27, 2024
11 of 12 checks passed
@roaks3 roaks3 deleted the revert-dcl-bump branch September 27, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants