-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed detection of not-run VCR tests to exclude non-vcr tests #11863
Merged
melinath
merged 1 commit into
GoogleCloudPlatform:main
from
melinath:fix-not-run-tests-regex
Sep 30, 2024
Merged
Fixed detection of not-run VCR tests to exclude non-vcr tests #11863
melinath
merged 1 commit into
GoogleCloudPlatform:main
from
melinath:fix-not-run-tests-regex
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melinath
requested review from
a team and
roaks3
and removed request for
a team
September 27, 2024 22:33
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
roaks3
approved these changes
Sep 30, 2024
anavada
pushed a commit
to anavada/magic-modules
that referenced
this pull request
Sep 30, 2024
karolgorc
pushed a commit
to karolgorc/magic-modules
that referenced
this pull request
Oct 4, 2024
niharika-98
pushed a commit
to niharika-98/magic-modules
that referenced
this pull request
Oct 7, 2024
trodge
pushed a commit
to trodge/magic-modules
that referenced
this pull request
Oct 10, 2024
karolgorc
pushed a commit
to karolgorc/magic-modules
that referenced
this pull request
Oct 11, 2024
gontech
pushed a commit
to gontech/magic-modules
that referenced
this pull request
Oct 16, 2024
BBBmau
pushed a commit
to BBBmau/magic-modules
that referenced
this pull request
Oct 23, 2024
BBBmau
pushed a commit
to BBBmau/magic-modules
that referenced
this pull request
Oct 24, 2024
BBBmau
pushed a commit
to BBBmau/magic-modules
that referenced
this pull request
Nov 5, 2024
akshat-jindal-nit
pushed a commit
to akshat-jindal-nit/magic-modules
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11750 (comment) for an example misdetection
Release Note Template for Downstream PRs (will be copied)