Enable update in apigee reference

[george-peng]

Add update capability to allow the reference to be updated without needing to recreate the entire resource.

Update API : https://cloud.google.com/apigee/docs/reference/apis/apigee/rest/v1/organizations.environments.references/update

Release Note Template for Downstream PRs (will be copied)

apigee: added update support for `google_apigee_env_references`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 277 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 277 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 44
Passed tests: 14
Skipped tests: 29
Affected tests: 1

Click here to see the affected service packages

• apigee

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTest_Update

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTest_Update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 277 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 277 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 44
Passed tests: 14
Skipped tests: 29
Affected tests: 1

Click here to see the affected service packages

• apigee

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTest_Update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTest_Update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 277 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 277 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 44
Passed tests: 14
Skipped tests: 29
Affected tests: 1

Click here to see the affected service packages

• apigee

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTest_Update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTest_Update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[george-peng]

@NickElliot what's the error in TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTest_Update? I don't have access to log.

[github-actions]

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[NickElliot]

Sorry for the delays

{
  "error": {
    "code": 400,
    "message": "generic::failed_precondition: keystore \"organizations/tf-testrr2t3aojrz/environments/tf-testrr2t3aojrz/keystores/tf-test-keystorerr2t3aojrz\" is referred to by reference \"organizations/tf-testrr2t3aojrz/environments/tf-testrr2t3aojrz/references/tf-test-referencerr2t3aojrz\"",
    "status": "FAILED_PRECONDITION",
    "details": [
      {
        "@type": "type.googleapis.com/google.rpc.RequestInfo",
        "requestId": "5975689308291936023"
      }
    ]
  }
}

The issue appears to be due to updating the dependent resource at the same time as the deletion -- the swap in dependency from apigee_environment_keystore_1 to apigee_environment_keystore_2seems to be the cause. Create both of the keystores in the step 1, then update the reference to apigee_environment_keystore_2 in step 2 (rather than comboing deletions/updates).

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 291 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 291 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 48
Passed tests: 14
Skipped tests: 33
Affected tests: 1

Click here to see the affected service packages

• apigee

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTest_Update

Get to know how VCR tests work

[NickElliot]

need these back!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 291 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 291 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 48
Passed tests: 14
Skipped tests: 33
Affected tests: 1

Click here to see the affected service packages

• apigee

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTest_Update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTest_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 293 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 293 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 49
Passed tests: 14
Skipped tests: 34
Affected tests: 1

Click here to see the affected service packages

• apigee

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTest_Update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccApigeeEnvReferences_apigeeEnvironmentReferenceTest_Update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[NickElliot]

LGTM