-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add google_oracle_database_cloud_exadata_infrastructure resource #11879
Feat: Add google_oracle_database_cloud_exadata_infrastructure resource #11879
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_oracle_database_cloud_exadata_infrastructure" "primary" {
gcp_oracle_zone = # value needed
labels = # value needed
properties {
cpu_count = # value needed
customer_contacts {
email = # value needed
}
db_node_storage_size_gb = # value needed
maintenance_window {
custom_action_timeout_mins = # value needed
days_of_week = # value needed
hours_of_day = # value needed
is_custom_action_timeout_enabled = # value needed
lead_time_week = # value needed
months = # value needed
patching_mode = # value needed
preference = # value needed
weeks_of_month = # value needed
}
memory_size_gb = # value needed
total_storage_size_gb = # value needed
}
}
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of changes needed:
- Add a beta version of the service to product.yaml. This will automatically generate a beta version of the resource.
- Add the
oracledatabase
service tommv1/third_party/terraform/.teamcity/components/inputs/services_beta.kt
andmmv1/third_party/terraform/.teamcity/components/inputs/services_ga.kt
- Add a test covering as many fields of the resource as possible. See missing test report
- Address errors from VCR-test, if any, once it completes
Tests analyticsTotal tests: 4117 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_oracle_database_cloud_exadata_infrastructure" "primary" {
labels = # value needed
}
|
mmv1/templates/terraform/examples/oracledatabase_cloud_exadatainfrastructure_full.tf.tmpl
Outdated
Show resolved
Hide resolved
Tests analyticsTotal tests: 4140 Click here to see the affected service packages
Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
We have granted SA iam permission to run the tests |
…database_cloud_exadata_infrastructure
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 4147 Click here to see the affected service packages
Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 4150 Click here to see the affected service packages
Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's just add links to the cloud.google.com documentation.
add links to the cloud.google.com documentation. Co-authored-by: Thomas Rodgers <[email protected]>
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 4152 Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
GoogleCloudPlatform#11879) Co-authored-by: Thomas Rodgers <[email protected]>
GoogleCloudPlatform#11879) Co-authored-by: Thomas Rodgers <[email protected]>
GoogleCloudPlatform#11879) Co-authored-by: Thomas Rodgers <[email protected]>
GoogleCloudPlatform#11879) Co-authored-by: Thomas Rodgers <[email protected]>
GoogleCloudPlatform#11879) Co-authored-by: Thomas Rodgers <[email protected]>
GoogleCloudPlatform#11879) Co-authored-by: Thomas Rodgers <[email protected]>
GoogleCloudPlatform#11879) Co-authored-by: Thomas Rodgers <[email protected]>
GoogleCloudPlatform#11879) Co-authored-by: Thomas Rodgers <[email protected]>
Part of: hashicorp/terraform-provider-google#19701
Release Note Template for Downstream PRs (will be copied)