Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add google_oracle_database_cloud_exadata_infrastructure resource #11879

Conversation

tulika-aakriti
Copy link
Contributor

@tulika-aakriti tulika-aakriti commented Oct 1, 2024

Part of: hashicorp/terraform-provider-google#19701

Release Note Template for Downstream PRs (will be copied)

`google_oracle_database_cloud_exadata_infrastructure`

@github-actions github-actions bot requested a review from trodge October 1, 2024 09:36
Copy link

github-actions bot commented Oct 1, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Oct 1, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 2364 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 12 files changed, 2364 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 540 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 111 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_cloud_exadata_infrastructure (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_cloud_exadata_infrastructure" "primary" {
  gcp_oracle_zone = # value needed
  labels          = # value needed
  properties {
    cpu_count = # value needed
    customer_contacts {
      email = # value needed
    }
    db_node_storage_size_gb = # value needed
    maintenance_window {
      custom_action_timeout_mins       = # value needed
      days_of_week                     = # value needed
      hours_of_day                     = # value needed
      is_custom_action_timeout_enabled = # value needed
      lead_time_week                   = # value needed
      months                           = # value needed
      patching_mode                    = # value needed
      preference                       = # value needed
      weeks_of_month                   = # value needed
    }
    memory_size_gb        = # value needed
    total_storage_size_gb = # value needed
  }
}

trodge
trodge previously requested changes Oct 1, 2024
Copy link
Contributor

@trodge trodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of changes needed:

  • Add a beta version of the service to product.yaml. This will automatically generate a beta version of the resource.
  • Add the oracledatabase service to mmv1/third_party/terraform/.teamcity/components/inputs/services_beta.kt and mmv1/third_party/terraform/.teamcity/components/inputs/services_ga.kt
  • Add a test covering as many fields of the resource as possible. See missing test report
  • Address errors from VCR-test, if any, once it completes

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4117
Passed tests: 3702
Skipped tests: 413
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocCluster_withAutoscalingPolicy
  • TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadatainfrastructureBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataprocCluster_withAutoscalingPolicy[Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadatainfrastructureBasicExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from trodge October 3, 2024 09:43
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 3, 2024
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 3, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 2464 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 12 files changed, 2454 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 540 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 240 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_oracle_database_cloud_exadata_infrastructure (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_oracle_database_cloud_exadata_infrastructure" "primary" {
  labels = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4140
Passed tests: 3717
Skipped tests: 416
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample
  • TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataformRepository_updated
  • TestAccDataprocCluster_withAutoscalingPolicy
  • TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadatainfrastructureBasicExample
  • TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadatainfrastructureFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Error message] [Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Error message] [Debug log]
TestAccDataformRepository_updated[Error message] [Debug log]
TestAccDataprocCluster_withAutoscalingPolicy[Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadatainfrastructureBasicExample[Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadatainfrastructureFullExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from trodge October 7, 2024 14:59
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 7, 2024
@tulika-aakriti
Copy link
Contributor Author

We have granted SA iam permission to run the tests

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 8, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 2456 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 12 files changed, 2446 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 540 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4147
Passed tests: 3724
Skipped tests: 416
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample
  • TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataformRepository_updated
  • TestAccDataprocCluster_withAutoscalingPolicy
  • TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadatainfrastructureBasicExample
  • TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadatainfrastructureFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Error message] [Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Error message] [Debug log]
TestAccDataformRepository_updated[Error message] [Debug log]
TestAccDataprocCluster_withAutoscalingPolicy[Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadatainfrastructureBasicExample[Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadatainfrastructureFullExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 2472 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 12 files changed, 2462 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 540 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 243 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4150
Passed tests: 3726
Skipped tests: 417
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample
  • TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataformRepository_updated
  • TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadataInfrastructureBasicExample
  • TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadataInfrastructureFullExample
  • TestAccServiceAccountIamPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadataInfrastructureBasicExample[Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadataInfrastructureFullExample[Debug log]
TestAccServiceAccountIamPolicy[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Error message] [Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Error message] [Debug log]
TestAccDataformRepository_updated[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@trodge trodge dismissed their stale review October 9, 2024 18:44

stale

Copy link
Contributor

@trodge trodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's just add links to the cloud.google.com documentation.

add links to the cloud.google.com documentation.

Co-authored-by: Thomas Rodgers <[email protected]>
@github-actions github-actions bot requested a review from trodge October 9, 2024 18:48
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 2477 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 12 files changed, 2467 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 540 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 243 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4152
Passed tests: 3731
Skipped tests: 417
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample
  • TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataformRepository_updated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Error message] [Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Error message] [Debug log]
TestAccDataformRepository_updated[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

trodge added a commit to trodge/magic-modules that referenced this pull request Oct 10, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 10, 2024
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants