-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation to list global
as the only supported location for logging resource LogScope
#11882
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 77 Click here to see the affected service packages
🟢 All tests passed! View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this fix!
global
the only supported location for logging resource LogScope
global
as the only supported location for logging resource LogScope
…for logging resource `LogScope` (GoogleCloudPlatform#11882)
…for logging resource `LogScope` (GoogleCloudPlatform#11882)
…for logging resource `LogScope` (GoogleCloudPlatform#11882)
…for logging resource `LogScope` (GoogleCloudPlatform#11882)
…for logging resource `LogScope` (GoogleCloudPlatform#11882)
…for logging resource `LogScope` (GoogleCloudPlatform#11882)
…for logging resource `LogScope` (GoogleCloudPlatform#11882)
…for logging resource `LogScope` (GoogleCloudPlatform#11882)
…for logging resource `LogScope` (GoogleCloudPlatform#11882)
Only updating the public doc to make
global
the only supported location for logging resource LogScope.We only support global for logging resource LogScope, so updating the public doc to reflect that.
The error handling will be added in a follow up PR since a test is broken by a different service and I'm not able to test it.
Error:
google-beta/services/compute/data_source_google_compute_region_instance_group_manager.go:28:30: undefined: tpgresource.ParseRegionalInstanceGroupManagersFieldValue
make: *** [GNUmakefile:29: vet] Error 1