Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to list global as the only supported location for logging resource LogScope #11882

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

tyh2333
Copy link
Contributor

@tyh2333 tyh2333 commented Oct 1, 2024

Only updating the public doc to make global the only supported location for logging resource LogScope.

We only support global for logging resource LogScope, so updating the public doc to reflect that.
The error handling will be added in a follow up PR since a test is broken by a different service and I'm not able to test it.

Error:
google-beta/services/compute/data_source_google_compute_region_instance_group_manager.go:28:30: undefined: tpgresource.ParseRegionalInstanceGroupManagersFieldValue
make: *** [GNUmakefile:29: vet] Error 1

@github-actions github-actions bot requested a review from SarahFrench October 1, 2024 17:30
Copy link

github-actions bot commented Oct 1, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/logging and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Oct 1, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 77
Passed tests: 75
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • logging

🟢 All tests passed!

View the build log

Copy link
Contributor

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this fix!

@SarahFrench SarahFrench changed the title Make global the only supported location for logging resource LogScope Update documentation to list global as the only supported location for logging resource LogScope Oct 1, 2024
@SarahFrench SarahFrench merged commit c8de2fa into GoogleCloudPlatform:main Oct 1, 2024
14 of 15 checks passed
karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 4, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
trodge pushed a commit to trodge/magic-modules that referenced this pull request Oct 10, 2024
karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 11, 2024
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants