Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples about how to make major release test projects in TeamCity #11888

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

SarahFrench
Copy link
Contributor

@SarahFrench SarahFrench commented Oct 2, 2024

Updates this contribution guide to link to past PRs for making major release test project in TeamCity.
It links to the PRs used for 6.0, and links to a draft PR that has the necessary changes for 7.0

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 6 insertions(+), 1 deletion(-))

@SarahFrench SarahFrench requested a review from shuyama1 October 2, 2024 12:55
@SarahFrench SarahFrench marked this pull request as ready for review October 2, 2024 18:55
Copy link

github-actions bot commented Oct 7, 2024

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the examples in the doc and creating a draft PR for 7.0 testing

@SarahFrench SarahFrench merged commit b8be569 into main Oct 7, 2024
14 checks passed
trodge pushed a commit to trodge/magic-modules that referenced this pull request Oct 10, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 10, 2024
karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 11, 2024
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
@SarahFrench SarahFrench deleted the SarahFrench-patch-2 branch November 5, 2024 16:07
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants