Allow for setting desired_status to different values than "RUNNING" on creation of google_compute_instance
#11902
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1 Click here to see the affected service packages
Tests were added that are skipped in VCR:
View the build log |
|
Hi, Don't have access to the build log. Can you paste what failed? |
|
@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 2 weeks. Please take a look! Use the label |
mmv1/third_party/terraform/services/compute/resource_compute_instance.go.tmpl
Show resolved
Hide resolved
modular-magician
added
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1037 Click here to see the affected service packages
Action takenFound 162 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
These 2 failing seem unrelated. |
|
/gcbrun |
modular-magician
added
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1040 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
| if err != nil { | ||
| return fmt.Errorf("Error waiting for status: %s", err) | ||
| } | ||
|
|
||
| if val, ok := d.GetOk("desired_status"); ok { | ||
| if val.(string) != "RUNNING" { | ||
| err = changeInstanceStatusOnCreation(config, d, project, zone.Name, d.Get("desired_status").(string), userAgent) |
There was a problem hiding this comment.
it all looks good only thing i would say is we can change d.Get("desired_status").(string) to be val.(string)
maybe even add a line that does status := val.(string)
modular-magician
added
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 1040 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
… on creation of `google_compute_instance` (GoogleCloudPlatform#11902)
… on creation of `google_compute_instance` (GoogleCloudPlatform#11902)
… on creation of `google_compute_instance` (GoogleCloudPlatform#11902)
closes hashicorp/terraform-provider-google#16586
Release Note Template for Downstream PRs (will be copied)