Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wording on folder & project for how tags works #11910

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

slevenick
Copy link
Contributor

Fixes: hashicorp/terraform-provider-google#19687

These are the only 2 current creation-only tags

Release Note Template for Downstream PRs (will be copied)


@slevenick slevenick requested review from a team and shuyama1 and removed request for a team October 3, 2024 17:59
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 4 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 4 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_folder (147 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_folder" "primary" {
  tags = # value needed
}

Resource: google_project (930 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_project" "primary" {
  tags = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 147
Passed tests: 117
Skipped tests: 30
Affected tests: 0

Click here to see the affected service packages
  • resourcemanager

🟢 All tests passed!

View the build log

@slevenick slevenick merged commit 87048ba into GoogleCloudPlatform:main Oct 10, 2024
12 checks passed
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document creation-only tags fields as creation-only
3 participants