Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force send internal_ip_only #11923

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

slevenick
Copy link
Contributor

This overrides the server-side default and keeps our default of false.
Fixes: hashicorp/terraform-provider-google#19522
Fixes: hashicorp/terraform-provider-google#19424

Release Note Template for Downstream PRs (will be copied)

dataproc: fixed a bug in `google_dataproc_cluster` that prevented creation of clusters with `internal_ip_only` set to false

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+))
google-beta provider: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 62
Passed tests: 20
Skipped tests: 6
Affected tests: 36

Click here to see the affected service packages
  • dataproc

Action taken

Found 36 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocClusterIamBinding
  • TestAccDataprocClusterIamMember
  • TestAccDataprocClusterIamPolicy
  • TestAccDataprocCluster_KMS
  • TestAccDataprocCluster_nonPreemptibleSecondary
  • TestAccDataprocCluster_singleNodeCluster
  • TestAccDataprocCluster_spotSecondary
  • TestAccDataprocCluster_withAccelerators
  • TestAccDataprocCluster_withAutoscalingPolicy
  • TestAccDataprocCluster_withConfigOverrides
  • TestAccDataprocCluster_withDataprocMetricConfig
  • TestAccDataprocCluster_withEndpointConfig
  • TestAccDataprocCluster_withImageVersion
  • TestAccDataprocCluster_withInitAction
  • TestAccDataprocCluster_withKerberos
  • TestAccDataprocCluster_withLabels
  • TestAccDataprocCluster_withLifecycleConfigIdleDeleteTtl
  • TestAccDataprocCluster_withMetadataAndTags
  • TestAccDataprocCluster_withMinNumInstances
  • TestAccDataprocCluster_withNodeGroupAffinity
  • TestAccDataprocCluster_withOptionalComponents
  • TestAccDataprocCluster_withReservationAffinity
  • TestAccDataprocCluster_withServiceAcc
  • TestAccDataprocCluster_withStagingBucket
  • TestAccDataprocCluster_withTempBucket
  • TestAccDataprocJobIamBinding
  • TestAccDataprocJobIamMember
  • TestAccDataprocJobIamPolicy
  • TestAccDataprocJob_Hadoop
  • TestAccDataprocJob_Hive
  • TestAccDataprocJob_Pig
  • TestAccDataprocJob_Presto
  • TestAccDataprocJob_PySpark
  • TestAccDataprocJob_Spark
  • TestAccDataprocJob_SparkSql
  • TestAccDataprocJob_updatable

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataprocClusterIamBinding[Debug log]
TestAccDataprocClusterIamMember[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]
TestAccDataprocCluster_KMS[Debug log]
TestAccDataprocCluster_nonPreemptibleSecondary[Debug log]
TestAccDataprocCluster_singleNodeCluster[Debug log]
TestAccDataprocCluster_spotSecondary[Debug log]
TestAccDataprocCluster_withAutoscalingPolicy[Debug log]
TestAccDataprocCluster_withConfigOverrides[Debug log]
TestAccDataprocCluster_withDataprocMetricConfig[Debug log]
TestAccDataprocCluster_withEndpointConfig[Debug log]
TestAccDataprocCluster_withImageVersion[Debug log]
TestAccDataprocCluster_withKerberos[Debug log]
TestAccDataprocCluster_withLabels[Debug log]
TestAccDataprocCluster_withLifecycleConfigIdleDeleteTtl[Debug log]
TestAccDataprocCluster_withMetadataAndTags[Debug log]
TestAccDataprocCluster_withMinNumInstances[Debug log]
TestAccDataprocCluster_withOptionalComponents[Debug log]
TestAccDataprocCluster_withReservationAffinity[Debug log]
TestAccDataprocJobIamBinding[Debug log]
TestAccDataprocJobIamMember[Debug log]
TestAccDataprocJobIamPolicy[Debug log]
TestAccDataprocJob_Hadoop[Debug log]
TestAccDataprocJob_Hive[Debug log]
TestAccDataprocJob_Pig[Debug log]
TestAccDataprocJob_PySpark[Debug log]
TestAccDataprocJob_Spark[Debug log]
TestAccDataprocJob_SparkSql[Debug log]
TestAccDataprocJob_updatable[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccDataprocCluster_withAccelerators[Error message] [Debug log]
TestAccDataprocCluster_withInitAction[Error message] [Debug log]
TestAccDataprocCluster_withNodeGroupAffinity[Error message] [Debug log]
TestAccDataprocCluster_withServiceAcc[Error message] [Debug log]
TestAccDataprocCluster_withStagingBucket[Error message] [Debug log]
TestAccDataprocCluster_withTempBucket[Error message] [Debug log]
TestAccDataprocJob_Presto[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 13 insertions(+))
google-beta provider: Diff ( 3 files changed, 13 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 62
Passed tests: 49
Skipped tests: 6
Affected tests: 7

Click here to see the affected service packages
  • dataproc

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocCluster_withAccelerators
  • TestAccDataprocCluster_withInitAction
  • TestAccDataprocCluster_withNodeGroupAffinity
  • TestAccDataprocCluster_withServiceAcc
  • TestAccDataprocCluster_withStagingBucket
  • TestAccDataprocCluster_withTempBucket
  • TestAccDataprocJob_Presto

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataprocCluster_withAccelerators[Debug log]
TestAccDataprocCluster_withInitAction[Debug log]
TestAccDataprocCluster_withNodeGroupAffinity[Debug log]
TestAccDataprocCluster_withServiceAcc[Debug log]
TestAccDataprocCluster_withStagingBucket[Debug log]
TestAccDataprocCluster_withTempBucket[Debug log]
TestAccDataprocJob_Presto[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@slevenick slevenick merged commit 991966b into GoogleCloudPlatform:main Oct 8, 2024
11 checks passed
trodge pushed a commit to trodge/magic-modules that referenced this pull request Oct 10, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 10, 2024
karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 11, 2024
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataproc Cluster unable to create with internal_ip_only = false Failing test(s): TestAccDataprocCluster*
3 participants