Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestAccComposer1Environment_withNodeConfig #11926

Conversation

ScottSuarez
Copy link
Contributor

Fix flakey test due to permission not having time to propagate

https://hashicorp.teamcity.com/test/-6915189059560242933?currentProjectId=TerraformProviders_GoogleCloud_GOOGLE_NIGHTLYTESTS&expandTestHistoryChartSection=true

------- Stdout: -------
=== RUN   TestAccComposer1Environment_withNodeConfig
=== PAUSE TestAccComposer1Environment_withNodeConfig
=== CONT  TestAccComposer1Environment_withNodeConfig
    resource_composer_environment_test.go:850: Step 1/3 error: Error running apply: exit status 1
        Error: Error waiting to create Environment: Error waiting for Creating Environment: Error code 9, message: Failed to create environment, but no error was surfaced. This can be caused by a lack of proper permissions. Check if this environment's service [email protected] has the 'roles/composer.worker' role and there is no firewall inhibiting internal communications set. In case, it is a Compute default service account it should have Editor permissions. For the required permissions information, please, refer to https://cloud.google.com/composer/docs/how-to/access-control  https://cloud.google.com/composer/docs/troubleshooting-environment-creation page contains more troubleshooting instructions
          with google_composer_environment.test,
          on terraform_plugin_test.tf line 4, in resource "google_composer_environment" "test":
           4: resource "google_composer_environment" "test" {
--- FAIL: TestAccComposer1Environment_withNodeConfig (2737.56s)

Release Note Template for Downstream PRs (will be copied)


@ScottSuarez ScottSuarez requested review from a team and rileykarson and removed request for a team October 4, 2024 17:29
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 6 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 6 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 52
Passed tests: 48
Skipped tests: 3
Affected tests: 1

Click here to see the affected service packages
  • composer

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComposer1Environment_withNodeConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComposer1Environment_withNodeConfig[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 9 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 9 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 52
Passed tests: 49
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • composer

🟢 All tests passed!

View the build log

@ScottSuarez ScottSuarez merged commit 30dee30 into GoogleCloudPlatform:main Oct 4, 2024
10 checks passed
@ScottSuarez ScottSuarez deleted the fix-TestAccComposer1Environment_withNodeConfig branch October 4, 2024 18:57
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
trodge pushed a commit to trodge/magic-modules that referenced this pull request Oct 10, 2024
karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 11, 2024
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants