Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block backup vault creation tests to run in parallel #11939

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

Mehul3217
Copy link
Contributor

@Mehul3217 Mehul3217 commented Oct 8, 2024

Release Note Template for Downstream PRs (will be copied)

netapp: block google_cloud_netapp_backup_vaults tests to run in parallel

@github-actions github-actions bot requested a review from BBBmau October 8, 2024 09:24
Copy link

github-actions bot commented Oct 8, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 34 insertions(+), 38 deletions(-))
google-beta provider: Diff ( 4 files changed, 34 insertions(+), 38 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 16
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • netapp

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetappBackupPolicy_NetappBackupPolicyFullExample_update
  • TestAccNetappBackup_NetappBackupFull_update
  • TestAccNetappVolume_NetappVolumeBasicExample_update
  • TestAccNetappVolume_autoTieredNetappVolume_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetappBackupPolicy_NetappBackupPolicyFullExample_update[Debug log]
TestAccNetappBackup_NetappBackupFull_update[Debug log]
TestAccNetappVolume_NetappVolumeBasicExample_update[Debug log]
TestAccNetappVolume_autoTieredNetappVolume_update[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@BBBmau BBBmau merged commit 6ff722b into GoogleCloudPlatform:main Oct 15, 2024
13 checks passed
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
varshatumburu pushed a commit to varshatumburu/magic-modules that referenced this pull request Oct 19, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants