Add logging_settings and speech_settings to dialogflow_cx_agent/flow

[averbuks]

Add advanced_settings.logging_settings and advanced_settings.speech_settings to dialogflowcx_agent and dialogflowcx_flow resources

Fixes hashicorp/terraform-provider-google#15980

-->

Release Note Template for Downstream PRs (will be copied)

dialogflowcx: added `advanced_settings.logging_settings` and `advanced_settings.speech_settings` to `google_dialogflow_cx_agent` and `google_dialogflow_cx_flow`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 720 insertions(+), 18 deletions(-))
google-beta provider: Diff ( 8 files changed, 720 insertions(+), 18 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 244 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 32 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 29
Passed tests: 25
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages

• dialogflowcx

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDialogflowCXAgent_dialogflowcxAgentFullExample
• TestAccDialogflowCXAgent_update
• TestAccDialogflowCXFlow_dialogflowcxFlowFullExample
• TestAccDialogflowCXFlow_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDialogflowCXAgent_dialogflowcxAgentFullExample[Debug log]
TestAccDialogflowCXFlow_dialogflowcxFlowFullExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccDialogflowCXAgent_update[Error message] [Debug log]
TestAccDialogflowCXFlow_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 720 insertions(+), 18 deletions(-))
google-beta provider: Diff ( 8 files changed, 720 insertions(+), 18 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 244 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 32 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 29
Passed tests: 27
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• dialogflowcx

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDialogflowCXAgent_update
• TestAccDialogflowCXFlow_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccDialogflowCXAgent_update[Error message] [Debug log]
TestAccDialogflowCXFlow_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 717 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 8 files changed, 717 insertions(+), 27 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 244 insertions(+))
Open in Cloud Shell: Diff ( 2 files changed, 32 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 29
Passed tests: 27
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• dialogflowcx

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDialogflowCXAgent_update
• TestAccDialogflowCXFlow_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDialogflowCXAgent_update[Debug log]
TestAccDialogflowCXFlow_update[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[slevenick]

Can you set some of these to false in a separate step? Sometimes we see issues setting booleans to false values

[slevenick]

Or is that impossible to verify based on the ignore_read functionality? Have you tested setting the false value and seeing that it correctly sets it in the API?

[averbuks]

Hi @slevenick, I tested setting all values to true/false and it all works. The only issue is that one of the fields enableInteractionLogging automatically set to true if you completely remove logging_settings {} block which triggers permadiff. I have internal bug open and will keep an eye on it.
Indeed given that we have ignore_read, testing change to one of the fields does not make sense, but I tested it by hands back and force with curl and gcloud to make sure fields change after change to the TF config