Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating documentation for AlertPolicy import_format #11944

Closed
wants to merge 1 commit into from
Closed

Updating documentation for AlertPolicy import_format #11944

wants to merge 1 commit into from

Conversation

brokenthumbs
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)


@github-actions github-actions bot requested a review from roaks3 October 8, 2024 17:41
Copy link

github-actions bot commented Oct 8, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 8, 2024
@roaks3
Copy link
Contributor

roaks3 commented Oct 10, 2024

@brokenthumbs I'm not sure this change is necessary, since the name has this same format. Was there a specific issue you experienced? Per the closed issue that you linked, it seems like there was an issue with the project ids not matching, but I can't tell if that resulted in a problem (like, can the project_id on the resource be different from the project id used in the name?).

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark review pass

@brokenthumbs
Copy link
Contributor Author

@brokenthumbs I'm not sure this change is necessary, since the name has this same format. Was there a specific issue you experienced? Per the closed issue that you linked, it seems like there was an issue with the project ids not matching, but I can't tell if that resulted in a problem (like, can the project_id on the resource be different from the project id used in the name?).

Ah, I'm still pretty new to GCP, and I realized that gcloud alpha monitoring policies list shows the actual name of the alert policy, where I was confusing myself with the displayName. Mostly tricky because I couldn't find the actual name of the alert policy, until I ran that gcloud command.

Thanks for pointing out! I totally did not notice that the name already matches with the change I was proposing. Closing, as name is the correct import variable.

@github-actions github-actions bot requested a review from roaks3 October 11, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that need reviewer's approval to run presubmit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants