-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accesscontextmanager - Update ingress / egress array ordering semantics #11945
accesscontextmanager - Update ingress / egress array ordering semantics #11945
Conversation
…nordered semantics to fix permadiffs
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
This field doesn't seem to have any effect on the generated code. Was the intention to make these fields into sets? If so, that may be a breaking change. |
@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@trodge I was under the impression that we could ignore the ordering of fields without making them sets to avoid a breaking change but that only works for top level fields. Im looking for other work arounds because this is causing a permadiff and waiting till the next major release is not an option for some customers |
@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 2 weeks. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 3 weeks. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 4 weeks. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 5 weeks. Please take a look! Use the label |
Fixes a permadiff in ingress / egress fine grained resources in cases where the API returns a different ordering for lists.