Fixed preconfigured_waf_config permadiff causing rules being recreated

[matheusaleixo-cit]

Fixes a permadiff related to the preconfigured_waf_config field in google_compute_security_policy.
Also promotes preconfigured_waf_config to GA.

Part of: hashicorp/terraform-provider-google#16882, hashicorp/terraform-provider-google#18596

Release Note Template for Downstream PRs (will be copied)

compute: fixed permadiff on the `preconfigured_waf_config` field for `google_compute_security_policy` resource

compute: added `preconfigured_waf_config` field  to `google_compute_security_policy` resource (ga)

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 446 insertions(+), 21 deletions(-))
google-beta provider: Diff ( 3 files changed, 73 insertions(+), 6 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1028
Passed tests: 953
Skipped tests: 74
Affected tests: 1

Click here to see the affected service packages

• compute

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeSecurityPolicy_withPreconfiguredWafConfig[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[NickElliot]

LGTM! The only change I'm looking for is a comment that would explain the solution being implemented.

[NickElliot]

LGTM!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 448 insertions(+), 21 deletions(-))
google-beta provider: Diff ( 3 files changed, 75 insertions(+), 6 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1036
Passed tests: 963
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages

• compute

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

• TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  🟢 All tests passed!

View the build log

[github-actions]

This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

[github-actions]

@NickElliot This PR is approved and has been waiting for merge for 2 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.