Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout time to 20 minutes for cloudfunctions function #11949

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

hao-nan-li
Copy link
Contributor

@hao-nan-li hao-nan-li commented Oct 8, 2024

fixes hashicorp/terraform-provider-google#18094

Release Note Template for Downstream PRs (will be copied)

cloudfunctions: increased the timeouts to 20 minutes for `google_cloudfunctions_function` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 16
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • cloudfunctions

🟢 All tests passed!

View the build log

@hao-nan-li hao-nan-li marked this pull request as ready for review October 9, 2024 18:40
@hao-nan-li hao-nan-li requested a review from zli82016 October 9, 2024 18:40
@zli82016 zli82016 changed the title Increase timeout time to 30 minutes Increase timeout time to 20 minutes for cloudfunctions function Oct 9, 2024
Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 merged commit fc795a1 into GoogleCloudPlatform:main Oct 9, 2024
14 checks passed
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccCloudFunctionsFunction_cmek
3 participants