Update data_loss_prevention_discovery_config to include field support for OtherCloudDiscoveryTarget #12114

patrickmoy · 2024-10-24T08:49:50Z

Note that OtherCloudDiscoveryTarget currently only supports AWS S3 buckets in this update.

Release Note Template for Downstream PRs (will be copied)

dlp: added `other_cloud_target` and `other_cloud_starting_location` to `google_data_loss_prevention_discovery_config`

github-actions · 2024-10-24T08:50:27Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2024-10-24T09:01:31Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 2202 insertions(+), 608 deletions(-))
google-beta provider: Diff ( 3 files changed, 2202 insertions(+), 608 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 512 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_data_loss_prevention_discovery_config (26 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_data_loss_prevention_discovery_config" "primary" {
  other_cloud_starting_location {
    aws_location {
      all_asset_inventory_assets = # value needed
    }
  }
  targets {
    other_cloud_target {
      conditions {
        amazon_s3_bucket_conditions {
          bucket_types           = # value needed
          object_storage_classes = # value needed
        }
      }
      filter {
        single_resource {
          amazon_s3_bucket {
            aws_account {
              account_id = # value needed
            }
            bucket_name = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2024-10-24T09:03:16Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 2202 insertions(+), 608 deletions(-))
google-beta provider: Diff ( 3 files changed, 2202 insertions(+), 608 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 512 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_data_loss_prevention_discovery_config (26 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_data_loss_prevention_discovery_config" "primary" {
  other_cloud_starting_location {
    aws_location {
      all_asset_inventory_assets = # value needed
    }
  }
  targets {
    other_cloud_target {
      conditions {
        amazon_s3_bucket_conditions {
          bucket_types           = # value needed
          object_storage_classes = # value needed
        }
      }
      filter {
        single_resource {
          amazon_s3_bucket {
            aws_account {
              account_id = # value needed
            }
            bucket_name = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2024-10-24T09:07:19Z

Tests analytics

Total tests: 63
Passed tests: 62
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataLossPreventionDiscoveryConfig_Update

Get to know how VCR tests work

modular-magician · 2024-10-24T09:08:58Z

Tests analytics

Total tests: 63
Passed tests: 62
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataLossPreventionDiscoveryConfig_Update

Get to know how VCR tests work

modular-magician · 2024-10-24T09:12:34Z

🔴 Tests failed during RECORDING mode:
TestAccDataLossPreventionDiscoveryConfig_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-24T09:23:07Z

🔴 Tests failed during RECORDING mode:
TestAccDataLossPreventionDiscoveryConfig_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-24T12:53:01Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 2202 insertions(+), 608 deletions(-))
google-beta provider: Diff ( 3 files changed, 2202 insertions(+), 608 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 512 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_data_loss_prevention_discovery_config (26 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_data_loss_prevention_discovery_config" "primary" {
  other_cloud_starting_location {
    aws_location {
      all_asset_inventory_assets = # value needed
    }
  }
  targets {
    other_cloud_target {
      conditions {
        amazon_s3_bucket_conditions {
          bucket_types           = # value needed
          object_storage_classes = # value needed
        }
      }
      filter {
        single_resource {
          amazon_s3_bucket {
            aws_account {
              account_id = # value needed
            }
            bucket_name = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2024-10-24T12:58:59Z

Tests analytics

Total tests: 63
Passed tests: 62
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataLossPreventionDiscoveryConfig_Update

Get to know how VCR tests work

modular-magician · 2024-10-24T13:14:45Z

🔴 Tests failed during RECORDING mode:
TestAccDataLossPreventionDiscoveryConfig_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

patrickmoy · 2024-11-08T01:53:12Z

/gcbrun

modular-magician · 2024-11-08T02:05:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 2202 insertions(+), 608 deletions(-))
google-beta provider: Diff ( 3 files changed, 2202 insertions(+), 608 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 512 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_data_loss_prevention_discovery_config (26 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_data_loss_prevention_discovery_config" "primary" {
  other_cloud_starting_location {
    aws_location {
      all_asset_inventory_assets = # value needed
    }
  }
  targets {
    other_cloud_target {
      conditions {
        amazon_s3_bucket_conditions {
          bucket_types           = # value needed
          object_storage_classes = # value needed
        }
      }
      filter {
        single_resource {
          amazon_s3_bucket {
            aws_account {
              account_id = # value needed
            }
            bucket_name = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2024-11-08T02:13:52Z

Tests analytics

Total tests: 63
Passed tests: 62
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataLossPreventionDiscoveryConfig_Update

Get to know how VCR tests work

modular-magician · 2024-11-08T02:31:16Z

🔴 Tests failed during RECORDING mode:
TestAccDataLossPreventionDiscoveryConfig_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

patrickmoy · 2024-11-16T00:13:09Z

/gcbrun

patrickmoy · 2024-11-18T19:23:21Z

/gcbrun

patrickmoy · 2024-11-19T03:42:07Z

/gcbrun

patrickmoy · 2024-11-19T08:04:04Z

/gcbrun

SirGitsalot

One nit and a suggestion for a config addition, but otherwise LGTM!

SirGitsalot · 2024-11-20T23:55:15Z

mmv1/products/dlp/DiscoveryConfig.yaml

+      - name: 'awsLocation'
+        type: NestedObject
+        properties:
+          - name: 'accountId'


According to the docs it's possible to specify accountId or allAssetInventoryAssets, but not both. I'm not sure if leaving both unset is valid, but in either case you can improve the user experience by adding either:

conflicts to both fields, if they're allowed to be unset

exactly_one_of if one of them is required to be set

SirGitsalot · 2024-11-20T23:59:30Z

...terraform/services/datalossprevention/resource_data_loss_prevention_discovery_config_test.go

+}
+resource "google_organization_iam_member" "dlp_role" {
+    org_id = "%{organization}"
+	role    = "roles/dlp.orgdriver"


nit: there's some weird indentation in the test configs (GitHub doesn't show it, but I'll bet it's due to a combination of tabs and spaces)

SirGitsalot

If adding roles/dlp.admin will do the trick, that change will need to be made in the CI Terraform config

SirGitsalot · 2024-11-25T22:49:02Z

...terraform/services/datalossprevention/resource_data_loss_prevention_discovery_config_test.go

+	return acctest.Nprintf(`
+data "google_project" "project" {
+}
+resource "google_organization_iam_member" "service_agent" {


These IAM grants are the reason that the tests are failing on our CI system - the service account running the test doesn't have permission to make org-level IAM changes. What are the minimum IAM roles needed to create the config?

My reading of the docs makes me think that granting the SA running the test roles/dlp.admin at the org level will be enough to run the test:

If you don't have the Organization Administrator (roles/resourcemanager.organizationAdmin) or Security Admin (roles/iam.securityAdmin) role, you can still create a scan configuration. After you create the scan configuration, someone in your organization who has one of these roles must grant discovery access to the service agent.

Updated CI terraform config; will see if tests pass

github-actions · 2024-12-09T09:43:04Z

@patrickmoy, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

github-actions · 2024-12-23T09:41:49Z

@patrickmoy, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

github-actions · 2025-01-02T09:41:35Z

@patrickmoy, this PR is waiting for action from you. If no action is taken, this PR will be closed in 2 weekdays.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

patrickmoy · 2025-01-03T02:49:29Z

/gcbrun

zli82016 · 2025-01-03T21:38:26Z

/gcbrun

zli82016 · 2025-01-03T21:53:10Z

/gcbrun

modular-magician · 2025-01-03T22:04:08Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 2186 insertions(+), 607 deletions(-))
google-beta provider: Diff ( 3 files changed, 2186 insertions(+), 607 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 501 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_data_loss_prevention_discovery_config (26 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_data_loss_prevention_discovery_config" "primary" {
  other_cloud_starting_location {
    aws_location {
      all_asset_inventory_assets = # value needed
    }
  }
  targets {
    other_cloud_target {
      conditions {
        amazon_s3_bucket_conditions {
          bucket_types           = # value needed
          object_storage_classes = # value needed
        }
      }
      filter {
        single_resource {
          amazon_s3_bucket {
            aws_account {
              account_id = # value needed
            }
            bucket_name = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2025-01-03T22:09:21Z

Tests analytics

Total tests: 63
Passed tests: 62
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataLossPreventionDiscoveryConfig_Update

Get to know how VCR tests work

modular-magician · 2025-01-03T22:28:51Z

🔴 Tests failed during RECORDING mode:
TestAccDataLossPreventionDiscoveryConfig_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2025-01-07T09:42:18Z

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

patrickmoy · 2025-01-09T02:03:34Z

/gcbrun

modular-magician · 2025-01-09T02:14:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 2186 insertions(+), 607 deletions(-))
google-beta provider: Diff ( 3 files changed, 2186 insertions(+), 607 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 501 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_data_loss_prevention_discovery_config (26 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_data_loss_prevention_discovery_config" "primary" {
  other_cloud_starting_location {
    aws_location {
      all_asset_inventory_assets = # value needed
    }
  }
  targets {
    other_cloud_target {
      conditions {
        amazon_s3_bucket_conditions {
          bucket_types           = # value needed
          object_storage_classes = # value needed
        }
      }
      filter {
        single_resource {
          amazon_s3_bucket {
            aws_account {
              account_id = # value needed
            }
            bucket_name = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2025-01-09T02:14:59Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 2186 insertions(+), 607 deletions(-))
google-beta provider: Diff ( 3 files changed, 2186 insertions(+), 607 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 501 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_data_loss_prevention_discovery_config (26 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_data_loss_prevention_discovery_config" "primary" {
  other_cloud_starting_location {
    aws_location {
      all_asset_inventory_assets = # value needed
    }
  }
  targets {
    other_cloud_target {
      conditions {
        amazon_s3_bucket_conditions {
          bucket_types           = # value needed
          object_storage_classes = # value needed
        }
      }
      filter {
        single_resource {
          amazon_s3_bucket {
            aws_account {
              account_id = # value needed
            }
            bucket_name = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2025-01-09T02:19:46Z

Tests analytics

Total tests: 63
Passed tests: 62
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataLossPreventionDiscoveryConfig_Update

Get to know how VCR tests work

modular-magician · 2025-01-09T02:20:44Z

Tests analytics

Total tests: 63
Passed tests: 62
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataLossPreventionDiscoveryConfig_Update

Get to know how VCR tests work

modular-magician · 2025-01-09T02:23:06Z

🔴 Tests failed during RECORDING mode:
TestAccDataLossPreventionDiscoveryConfig_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-09T02:38:43Z

🔴 Tests failed during RECORDING mode:
TestAccDataLossPreventionDiscoveryConfig_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

…veryTarget, which currently only supports AWS S3 buckets.

patrickmoy · 2025-01-09T02:49:15Z

/gcbrun

modular-magician · 2025-01-09T02:59:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 2186 insertions(+), 607 deletions(-))
google-beta provider: Diff ( 3 files changed, 2186 insertions(+), 607 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 501 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_data_loss_prevention_discovery_config (26 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_data_loss_prevention_discovery_config" "primary" {
  other_cloud_starting_location {
    aws_location {
      all_asset_inventory_assets = # value needed
    }
  }
  targets {
    other_cloud_target {
      conditions {
        amazon_s3_bucket_conditions {
          bucket_types           = # value needed
          object_storage_classes = # value needed
        }
      }
      filter {
        single_resource {
          amazon_s3_bucket {
            aws_account {
              account_id = # value needed
            }
            bucket_name = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2025-01-09T03:00:31Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 2186 insertions(+), 607 deletions(-))
google-beta provider: Diff ( 3 files changed, 2186 insertions(+), 607 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 501 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_data_loss_prevention_discovery_config (26 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_data_loss_prevention_discovery_config" "primary" {
  other_cloud_starting_location {
    aws_location {
      all_asset_inventory_assets = # value needed
    }
  }
  targets {
    other_cloud_target {
      conditions {
        amazon_s3_bucket_conditions {
          bucket_types           = # value needed
          object_storage_classes = # value needed
        }
      }
      filter {
        single_resource {
          amazon_s3_bucket {
            aws_account {
              account_id = # value needed
            }
            bucket_name = # value needed
          }
        }
      }
    }
  }
}

modular-magician · 2025-01-09T03:05:25Z

Tests analytics

Total tests: 63
Passed tests: 62
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataLossPreventionDiscoveryConfig_Update

Get to know how VCR tests work

modular-magician · 2025-01-09T03:05:58Z

Tests analytics

Total tests: 63
Passed tests: 62
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataLossPreventionDiscoveryConfig_Update

Get to know how VCR tests work

modular-magician · 2025-01-09T03:09:06Z

🔴 Tests failed during RECORDING mode:
TestAccDataLossPreventionDiscoveryConfig_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-09T03:24:55Z

🔴 Tests failed during RECORDING mode:
TestAccDataLossPreventionDiscoveryConfig_Update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2025-01-09T09:41:53Z

@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions bot requested a review from SirGitsalot October 24, 2024 08:50

patrickmoy force-pushed the main branch from 57e7ab6 to 783d8ed Compare October 24, 2024 08:52

modular-magician added the service/dlp label Oct 24, 2024

modular-magician requested a review from catherinerosesantos October 24, 2024 09:01

patrickmoy force-pushed the main branch from 783d8ed to 64c7cd1 Compare October 24, 2024 12:41

patrickmoy marked this pull request as draft October 24, 2024 18:59

patrickmoy force-pushed the main branch from 64c7cd1 to 35a39f7 Compare November 18, 2024 18:48

patrickmoy marked this pull request as ready for review November 19, 2024 08:02

patrickmoy force-pushed the main branch from 6863948 to 917c1a5 Compare November 19, 2024 08:40

patrickmoy marked this pull request as draft November 19, 2024 18:59

patrickmoy marked this pull request as ready for review November 19, 2024 20:25

SirGitsalot reviewed Nov 21, 2024

View reviewed changes

SirGitsalot reviewed Nov 25, 2024

View reviewed changes

github-actions bot requested a review from SirGitsalot January 3, 2025 02:47

patrickmoy force-pushed the main branch from 96a4140 to 6d95531 Compare January 9, 2025 02:02

Add data_loss_prevention_discovery_config support for OtherCloudDisco…

e645e44

…veryTarget, which currently only supports AWS S3 buckets.

patrickmoy force-pushed the main branch from 6d95531 to e645e44 Compare January 9, 2025 02:48

Update data_loss_prevention_discovery_config to include field support for OtherCloudDiscoveryTarget #12114

Are you sure you want to change the base?

Update data_loss_prevention_discovery_config to include field support for OtherCloudDiscoveryTarget #12114

Conversation

patrickmoy commented Oct 24, 2024

github-actions bot commented Oct 24, 2024

modular-magician commented Oct 24, 2024

Diff report

Missing test report

modular-magician commented Oct 24, 2024

Diff report

Missing test report

modular-magician commented Oct 24, 2024

Tests analytics

Action taken

modular-magician commented Oct 24, 2024

Tests analytics

Action taken

modular-magician commented Oct 24, 2024

modular-magician commented Oct 24, 2024

modular-magician commented Oct 24, 2024

Diff report

Missing test report

modular-magician commented Oct 24, 2024

Tests analytics

Action taken

modular-magician commented Oct 24, 2024

patrickmoy commented Nov 8, 2024

modular-magician commented Nov 8, 2024

Diff report

Missing test report

modular-magician commented Nov 8, 2024

Tests analytics

Action taken

modular-magician commented Nov 8, 2024

patrickmoy commented Nov 16, 2024

patrickmoy commented Nov 18, 2024

patrickmoy commented Nov 19, 2024

patrickmoy commented Nov 19, 2024

SirGitsalot left a comment

Choose a reason for hiding this comment

SirGitsalot Nov 20, 2024

Choose a reason for hiding this comment

SirGitsalot Nov 20, 2024

Choose a reason for hiding this comment

SirGitsalot left a comment

Choose a reason for hiding this comment

SirGitsalot Nov 25, 2024

Choose a reason for hiding this comment

patrickmoy Jan 3, 2025

Choose a reason for hiding this comment

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Jan 2, 2025

patrickmoy commented Jan 3, 2025

zli82016 commented Jan 3, 2025

zli82016 commented Jan 3, 2025

modular-magician commented Jan 3, 2025

Diff report

Missing test report

modular-magician commented Jan 3, 2025

Tests analytics

Action taken

modular-magician commented Jan 3, 2025

github-actions bot commented Jan 7, 2025

patrickmoy commented Jan 9, 2025

modular-magician commented Jan 9, 2025

Diff report

Missing test report

modular-magician commented Jan 9, 2025

Diff report

Missing test report

modular-magician commented Jan 9, 2025

Tests analytics

Action taken

modular-magician commented Jan 9, 2025

Tests analytics

Action taken

modular-magician commented Jan 9, 2025

modular-magician commented Jan 9, 2025