Redis cluster Multi vpc support

[himanikh]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_redis_cluster_user_created_connections`

redis: added `cluster_endpoints` and `psc_service_attachments` field to `google_redis_cluster` resource, to enable use of the fine-grained resource `google_redis_cluster_user_created_connections`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 803 insertions(+), 35 deletions(-))
google-beta provider: Diff ( 7 files changed, 803 insertions(+), 35 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 89 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 177 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_cluster (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster" "primary" {
  cluster_endpoints = # value needed
  psc_service_attachments {
    connection_type    = # value needed
    service_attachment = # value needed
  }
}

Resource: google_redis_cluster_user_created_connections (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster_user_created_connections" "primary" {
  cluster_endpoints = # value needed
}

[modular-magician]

Tests analytics

Total tests: 27
Passed tests: 26
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccRedisClusterUserCreatedConnections_redisClusterUserCreatedConnectionsExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccRedisClusterUserCreatedConnections_redisClusterUserCreatedConnectionsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 803 insertions(+), 35 deletions(-))
google-beta provider: Diff ( 7 files changed, 803 insertions(+), 35 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 89 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 177 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_cluster (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster" "primary" {
  cluster_endpoints = # value needed
  psc_service_attachments {
    connection_type    = # value needed
    service_attachment = # value needed
  }
}

Resource: google_redis_cluster_user_created_connections (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster_user_created_connections" "primary" {
  cluster_endpoints = # value needed
}

[modular-magician]

Tests analytics

Total tests: 27
Passed tests: 26
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccRedisClusterUserCreatedConnections_redisClusterUserCreatedConnectionsExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccRedisClusterUserCreatedConnections_redisClusterUserCreatedConnectionsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1818 insertions(+), 35 deletions(-))
google-beta provider: Diff ( 7 files changed, 1818 insertions(+), 35 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 476 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 178 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_cluster (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster" "primary" {
  cluster_endpoints {
    connections {
      psc_auto_connection {
        network    = # value needed
        project_id = # value needed
      }
    }
  }
  psc_service_attachments {
    connection_type    = # value needed
    service_attachment = # value needed
  }
}

Resource: google_redis_cluster_user_created_connections (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster_user_created_connections" "primary" {
  cluster_endpoints {
    connections {
      psc_connection {
        project_id = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 27
Passed tests: 26
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccRedisClusterUserCreatedConnections_redisClusterUserCreatedConnectionsExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccRedisClusterUserCreatedConnections_redisClusterUserCreatedConnectionsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 1811 insertions(+), 36 deletions(-))
google-beta provider: Diff ( 9 files changed, 1811 insertions(+), 36 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 466 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 178 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_cluster (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster" "primary" {
  cluster_endpoints {
    connections {
      psc_auto_connection {
        network    = # value needed
        project_id = # value needed
      }
    }
  }
  psc_service_attachments {
    connection_type    = # value needed
    service_attachment = # value needed
  }
}

Resource: google_redis_cluster_user_created_connections (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster_user_created_connections" "primary" {
  cluster_endpoints {
    connections {
      psc_connection {
        project_id = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 4373
Passed tests: 3947
Skipped tests: 421
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccDataSourceGoogleQuotaInfo_basic
• TestAccEphemeralServiceAccountKey_basic
• TestAccRedisClusterUserCreatedConnections_redisClusterUserCreatedConnectionsExample
• TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccRedisClusterUserCreatedConnections_redisClusterUserCreatedConnectionsExample [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[NickElliot]

      # google_compute_forwarding_rule.forwarding_rule1_network1 will be updated in-place

      ~ resource "google_compute_forwarding_rule" "forwarding_rule1_network1" {
            id                      = "projects/ci-test-project-188019/regions/us-central1/forwardingRules/forwardingrule11"
            name                    = "forwardingrule11"
          ~ target                  = "https://www.googleapis.com/compute/beta/projects/ma3f380586e1b5da2p-tp/regions/us-central1/serviceAttachments/gcp-memorystore-auto-3a9ed5c5-0e48-49-psc-sa" -> "https://www.googleapis.com/compute/v1/projects/91977256640/regions/us-central1/serviceAttachments/gcp-memorystore-auto-3a9ed5c5-0e48-49-psc-sa"
            # (28 unchanged attributes hidden)
    
            # (1 unchanged block hidden)
        }

It looks like this diff suppress isn't working fully, are you getting different results locally?

[himanikh]

Fixed the issue. It should work now. But facing this new issue https://paste.googleplex.com/5853800871755776

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1957 insertions(+), 36 deletions(-))
google-beta provider: Diff ( 10 files changed, 1957 insertions(+), 36 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 466 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 245 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_cluster (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster" "primary" {
  cluster_endpoints {
    connections {
      psc_auto_connection {
        network    = # value needed
        project_id = # value needed
      }
    }
  }
  psc_service_attachments {
    connection_type    = # value needed
    service_attachment = # value needed
  }
}

Resource: google_redis_cluster_user_created_connections (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster_user_created_connections" "primary" {
  cluster_endpoints {
    connections {
      psc_connection {
        project_id = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 4382
Passed tests: 3949
Skipped tests: 429
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccDataSourceGoogleQuotaInfo_basic
• TestAccEphemeralServiceAccountKey_basic
• TestAccRedisClusterUserCreatedConnections_redisClusterUserCreatedConnectionsExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[NickElliot]

add output:true to the subfields of the new output field block, not sure about the test failure, will see if it repeats on a rerun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1681 insertions(+), 36 deletions(-))
google-beta provider: Diff ( 10 files changed, 1681 insertions(+), 36 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 359 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 249 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_cluster_user_created_connections (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster_user_created_connections" "primary" {
  cluster_endpoints {
    connections {
      psc_connection {
        address            = # value needed
        forwarding_rule    = # value needed
        network            = # value needed
        project_id         = # value needed
        psc_connection_id  = # value needed
        service_attachment = # value needed
      }
    }
  }
  name = # value needed
}

[modular-magician]

Tests analytics

Total tests: 4383
Passed tests: 3950
Skipped tests: 429
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccDataSourceGoogleQuotaInfo_basic
• TestAccEphemeralServiceAccountKey_basic
• TestAccRedisClusterUserCreatedConnections_redisClusterUserCreatedConnectionsExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccRedisClusterUserCreatedConnections_redisClusterUserCreatedConnectionsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1681 insertions(+), 36 deletions(-))
google-beta provider: Diff ( 10 files changed, 1681 insertions(+), 36 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 359 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 249 insertions(+))

[modular-magician]

Tests analytics

Total tests: 4383
Passed tests: 3948
Skipped tests: 429
Affected tests: 6

Click here to see the affected service packages

All service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy
• TestAccDataSourceGoogleGkeHubFeature_basic
• TestAccDataSourceGoogleQuotaInfo_basic
• TestAccEphemeralServiceAccountKey_basic
• TestAccRedisClusterUserCreatedConnections_redisClusterUserCreatedConnectionsExample
• TestAccStorageTransferReplicationJob_basic

Get to know how VCR tests work

[himanikh]

LGTM, but wanted to ask for one last bit of clarification on the relationship between cluster and clusterUserCreatedConnections -- is the clusterEndpoints in redis_cluster distinct from the one in redis_cluster_user_created_connections? or is the latter a fine grained resource to represent the former?

It's the latter. ClusterEndpoints can have both user and auto created connections.
CUJ for User created endpoints is:

1. User creates cluster
2. User creates ForwardingRule based on ServiceAttachment returned from cluster created in step 1
3. User updates cluster in step 1 with forwarding rule in step 2.
   User created connections need to be presented as a separate binding resource to break the cyclic dependency between Cluster and forwardingRule.
   More details in https://yaqs.corp.google.com/eng/q/1746988736605847552

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 2296 insertions(+), 35 deletions(-))
google-beta provider: Diff ( 8 files changed, 2296 insertions(+), 35 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 359 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 459 insertions(+))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• redis

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccRedisClusterUserCreatedConnections_redisClusterUserAndAutoCreatedConnectionsExample
• TestAccRedisClusterUserCreatedConnections_redisClusterUserCreatedConnectionsExample
• TestAccRedisCluster_updateClusterEndpoints
  🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 2292 insertions(+), 35 deletions(-))
google-beta provider: Diff ( 8 files changed, 2292 insertions(+), 35 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 359 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 459 insertions(+))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• redis

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccRedisClusterUserCreatedConnections_redisClusterUserAndAutoCreatedConnectionsExample
• TestAccRedisClusterUserCreatedConnections_redisClusterUserCreatedConnectionsExample
• TestAccRedisCluster_updateClusterEndpoints
  🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1916 insertions(+), 35 deletions(-))
google-beta provider: Diff ( 8 files changed, 2215 insertions(+), 35 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 359 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 459 insertions(+))

[modular-magician]

Tests analytics

Total tests: 29
Passed tests: 28
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccRedisCluster_updateClusterEndpoints

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccRedisCluster_updateClusterEndpoints [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1915 insertions(+), 35 deletions(-))
google-beta provider: Diff ( 8 files changed, 2214 insertions(+), 35 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 359 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 459 insertions(+))

[modular-magician]

Tests analytics

Total tests: 29
Passed tests: 29
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• redis

🟢 All tests passed!

View the build log

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1511 insertions(+), 35 deletions(-))
google-beta provider: Diff ( 8 files changed, 1810 insertions(+), 35 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 209 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 459 insertions(+))

[modular-magician]

Tests analytics

Total tests: 29
Passed tests: 28
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• redis

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccRedisCluster_updateClusterEndpoints

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccRedisCluster_updateClusterEndpoints [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[NickElliot]

because the UserCreatedConnections has exclude_delete=true and what the function does when it is supplied "0" means the google_redis_cluster_user_created_connections resource is removed from plan entirely rather than processed as a change that needs to be applied

a custom delete will need to be added that applies the DELETE call as a patch command

[NickElliot]

there is no case for when userEndpointCount=0, making it equivalent to removing these resources from state

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1619 insertions(+), 35 deletions(-))
google-beta provider: Diff ( 8 files changed, 1918 insertions(+), 35 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 209 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 459 insertions(+))

[modular-magician]

Tests analytics

Total tests: 29
Passed tests: 26
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

• redis

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccRedisClusterUserCreatedConnections_redisClusterUserAndAutoCreatedConnectionsExample
• TestAccRedisClusterUserCreatedConnections_redisClusterUserCreatedConnectionsExample
• TestAccRedisCluster_updateClusterEndpoints

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccRedisClusterUserCreatedConnections_redisClusterUserAndAutoCreatedConnectionsExample [Error message] [Debug log]
TestAccRedisClusterUserCreatedConnections_redisClusterUserCreatedConnectionsExample [Error message] [Debug log]
TestAccRedisCluster_updateClusterEndpoints [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[NickElliot]

pending cyclic dependency design decision