-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add foreign type info and definition to google_bigquery_table beta #12659
base: main
Are you sure you want to change the base?
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 129 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 1 week. Please take a look! Use the label |
503dd0e
to
7eee044
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 129 Click here to see the affected service packages
🟢 All tests passed! View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to confirm if this feature is already released. Could you share the API doc? I couldn't find it on https://cloud.google.com/bigquery/docs/reference/rest/v2/tables. Also for the bigquery service, we use https://bigquery.googleapis.com/bigquery/v2/
for both GA and beta providers. Is there a specific reason this feature is limited to beta?
@@ -992,6 +1009,25 @@ func ResourceBigQueryTable() *schema.Resource { | |||
DiffSuppressFunc: bigQueryTableSchemaDiffSuppress, | |||
Description: `A JSON schema for the table.`, | |||
}, | |||
{{- if ne $.TargetVersionName "ga" }} | |||
// SchemaForeignTypeInfo: [Optional] Specifies metadata of the foreign data type definition in field schema. | |||
"schema_foreign_type_info": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this field support updates? If so, could we add an update step in the test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't and API will throw an error. The behavior might change between Public Preview and GA or post-GA, so we are also not making it force-new right now.
// TypeSystem: [Optional] Specifies the system which defines the foreign data type. | ||
"type_system": { | ||
Type: schema.TypeString, | ||
Optional: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this field required, given this is currently the only subfield?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this, it should be required.
7eee044
to
85188e8
Compare
This is scheduled for a Public Preview launch in January, hence beta-provider-only until GA. I will check with the API team to see when the public reference doc is expected to update. In the meantime you can find the corresponding definitions in internal search. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 129 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Add foreign type info and definition to
google_bigquery_table
beta.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.