Add support for new flags in node_kubelet_config.

[VeraQin]

The new flags include:

• container_log_max_size
• container_log_max_files
• image_gc_low_threshold_percent
• image_gc_high_threshold_percent
• image_minimum_gc_age
• image_maximum_gc_age
• allowed_unsafe_sysctls

Change-Id: If4be953da244d4c2b7a58a3d0cb958720a1eb609

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: added new fields `container_log_max_size`, `container_log_max_files`, `image_gc_low_threshold_percent`, `image_gc_high_threshold_percent`, `image_minimum_gc_age`, `image_maximum_gc_age`, and `allowed_unsafe_sysctls` to `node_kubelet_config` block. 

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 113 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 3 files changed, 113 insertions(+), 6 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• container

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[zli82016]

Build failed.

# github.com/hashicorp/terraform-provider-google-beta/google-beta/services/container [github.com/hashicorp/terraform-provider-google-beta/google-beta/services/container.test]
google-beta/services/container/node_config.go:1300:11: kConfig.ContainerLogMaxSize undefined (type *"google.golang.org/api/container/v1beta1".NodeKubeletConfig has no field or method ContainerLogMaxSize)
google-beta/services/container/node_config.go:1303:11: kConfig.ContainerLogMaxFiles undefined (type *"google.golang.org/api/container/v1beta1".NodeKubeletConfig has no field or method ContainerLogMaxFiles)
google-beta/services/container/node_config.go:1306:11: kConfig.ImageGcLowThresholdPercent undefined (type *"google.golang.org/api/container/v1beta1".NodeKubeletConfig has no field or method ImageGcLowThresholdPercent)
google-beta/services/container/node_config.go:1309:11: kConfig.ImageGcHighThresholdPercent undefined (type *"google.golang.org/api/container/v1beta1".NodeKubeletConfig has no field or method ImageGcHighThresholdPercent)
google-beta/services/container/node_config.go:1312:11: kConfig.ImageMinimumGcAge undefined (type *"google.golang.org/api/container/v1beta1".NodeKubeletConfig has no field or method ImageMinimumGcAge)
google-beta/services/container/node_config.go:1315:11: kConfig.ImageMaximumGcAge undefined (type *"google.golang.org/api/container/v1beta1".NodeKubeletConfig has no field or method ImageMaximumGcAge)
google-beta/services/container/node_config.go:1319:11: kConfig.allowedUnsafeSysctls undefined (type *"google.golang.org/api/container/v1beta1".NodeKubeletConfig has no field or method allowedUnsafeSysctls)
google-beta/services/container/node_config.go:1321:12: kConfig.AllowedUnsafeSysctls undefined (type *"google.golang.org/api/container/v1beta1".NodeKubeletConfig has no field or method AllowedUnsafeSysctls)
google-beta/services/container/node_config.go:1903:48: c.ContainerLogMaxSize undefined (type *"google.golang.org/api/container/v1beta1".NodeKubeletConfig has no field or method ContainerLogMaxSize)
google-beta/services/container/node_config.go:1904:48: c.ContainerLogMaxFiles undefined (type *"google.golang.org/api/container/v1beta1".NodeKubeletConfig has no field or method ContainerLogMaxFiles)
google-beta/services/container/node_config.go:1904:48: too many errors

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 113 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 3 files changed, 113 insertions(+), 6 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• container

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[zli82016]

Error: google/services/container/node_config.go:1246:11: kConfig.ContainerLogMaxSize undefined (type *"google.golang.org/api/container/v1".NodeKubeletConfig has no field or method ContainerLogMaxSize)
Error: google/services/container/node_config.go:1249:11: kConfig.ContainerLogMaxFiles undefined (type *"google.golang.org/api/container/v1".NodeKubeletConfig has no field or method ContainerLogMaxFiles)
Error: google/services/container/node_config.go:1252:11: kConfig.ImageGcLowThresholdPercent undefined (type *"google.golang.org/api/container/v1".NodeKubeletConfig has no field or method ImageGcLowThresholdPercent)
Error: google/services/container/node_config.go:1255:11: kConfig.ImageGcHighThresholdPercent undefined (type *"google.golang.org/api/container/v1".NodeKubeletConfig has no field or method ImageGcHighThresholdPercent)
Error: google/services/container/node_config.go:1258:11: kConfig.ImageMinimumGcAge undefined (type *"google.golang.org/api/container/v1".NodeKubeletConfig has no field or method ImageMinimumGcAge)
Error: google/services/container/node_config.go:1261:11: kConfig.ImageMaximumGcAge undefined (type *"google.golang.org/api/container/v1".NodeKubeletConfig has no field or method ImageMaximumGcAge)
Error: google/services/container/node_config.go:1265:11: kConfig.allowedUnsafeSysctls undefined (type *"google.golang.org/api/container/v1".NodeKubeletConfig has no field or method allowedUnsafeSysctls)
Error: google/services/container/node_config.go:1267:12: kConfig.AllowedUnsafeSysctls undefined (type *"google.golang.org/api/container/v1".NodeKubeletConfig has no field or method AllowedUnsafeSysctls)
Error: google/services/container/node_config.go:1763:48: c.ContainerLogMaxSize undefined (type *"google.golang.org/api/container/v1".NodeKubeletConfig has no field or method ContainerLogMaxSize)
Error: google/services/container/node_config.go:1764:48: c.ContainerLogMaxFiles undefined (type *"google.golang.org/api/container/v1".NodeKubeletConfig has no field or method ContainerLogMaxFiles)
Error: google/services/container/node_config.go:1764:48: too many errors

[zli82016]

@modular-magician reassign-reviewer

[zli82016]

Reassign the reviewer during my OOO

[shuyama1]

It doesn't look like these fields are currently supported https://pkg.go.dev/google.golang.org/[email protected]/container/v1beta1#NodeKubeletConfig.

[github-actions]

@VeraQin, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[VeraQin]

I find these new fields are already available in container api https://github.com/googleapis/google-api-go-client/blob/main/container/v1/container-api.json (same for v1beta1), why does the build still fails?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 113 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 3 files changed, 113 insertions(+), 6 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• container

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[shuyama1]

I find these new fields are already available in container api googleapis/google-api-go-client@main/container/v1/container-api.json (same for v1beta1), why does the build still fails?

Looks like these changes are added 4 days ago and haven't been release yet - the latest version v0.219.0 was released earlier.

Once the new version containing the features is released, you'll need to create a PR to update the dependency to the latest version and get it merge first. After that, the build for this PR should no longer fail.