Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google_chronicle_rule resource to chronicle #12720

Conversation

ankitgoyal0301
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_chronicle_rule`

Copy link

github-actions bot commented Jan 9, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from SirGitsalot January 9, 2025 12:50
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 308 insertions(+))
google-beta provider: Diff ( 6 files changed, 1468 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_rule (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_rule" "primary" {
  etag = # value needed
  severity {
    display_name = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 11
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • chronicle

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccChronicleRule_chronicleRuleBasicExample
  • TestAccChronicleRule_chronicleRuleBasicExample_update
  • TestAccChronicleRule_chronicleRuleWithDataAccessScopeExample
  • TestAccChronicleRule_chronicleRuleWithForceDeletionExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccChronicleRule_chronicleRuleBasicExample [Debug log]
TestAccChronicleRule_chronicleRuleBasicExample_update [Debug log]
TestAccChronicleRule_chronicleRuleWithDataAccessScopeExample [Debug log]
TestAccChronicleRule_chronicleRuleWithForceDeletionExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 308 insertions(+))
google-beta provider: Diff ( 6 files changed, 1468 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_rule (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_rule" "primary" {
  etag = # value needed
  severity {
    display_name = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • chronicle

🟢 All tests passed!

View the build log

'Google SecOps Guides': 'https://cloud.google.com/chronicle/docs/secops/secops-overview'
api: 'https://cloud.google.com/chronicle/docs/reference/rest/v1alpha/projects.locations.instances.rules'
base_url: projects/{{project}}/locations/{{location}}/instances/{{instance}}/rules
self_link: projects/{{project}}/locations/{{location}}/instances/{{instance}}/rules/{{name}}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's write ruleId here since name would be confusing. Same comments for below places.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 311 insertions(+))
google-beta provider: Diff ( 6 files changed, 1458 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_rule (5 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_rule" "primary" {
  etag    = # value needed
  rule_id = # value needed
  severity {
    display_name = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 14
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • chronicle

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccChronicleRule_chronicleRuleBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccChronicleRule_chronicleRuleBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants