fix: removing data access config from gke-setup #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucstjean-ssc
requested review from
Michael-McAuley-SSC,
davelanglois-ssc,
alaincormier-ssc,
stephanemillaire-ssc,
anoopsidhu-ssc and
borkodjurkovic-ssc
lucstjean-ssc
requested review from
cartyc and
fmichaelobrien
as code owners
alaincormier-ssc
approved these changes
Dec 13, 2023
davelanglois-ssc
approved these changes
Dec 13, 2023
cartyc
approved these changes
Dec 13, 2023
lucstjean-ssc
deleted the
gh762-fix-remove-data-access-log-config-gke
branch
Merged
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #762
As previously discussed, the choice of enabling data access logs falls onto the client. Therefore, we will be removing the data access configuration from the
gke-setuppackage.