feat!: Spring Cloud 2024.0 and Spring Boot 3.4.2 #3500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 290c7a2.
This reverts commit eaf04dc.
This reverts commit 0fabdbf.
This reverts commit 3eeef1e.
This reverts commit ce40125.
This reverts commit 4015f3f.
this prevents attempts of the form sm@my_secret:default as a whole string
This moves the @RefreshScope annotation to method-level in order to avoid build failures in the native image tests. A good candidate to prove it as good practice is https://github.com/spring-cloud/spring-cloud-commons/blob/c0f3a6190c5e636ac5391371b503f7f1e6e24a8e/docs/modules/ROOT/pages/spring-cloud-commons/application-context-services.adoc?plain=1#L211-L215 The native tests script will also override the refresh scope as it's explained in the docs (see implementation for link).
zhumin8
reviewed
Jan 24, 2025
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2024 Google LLC | |||
| * Copyright 2025 Google LLC | |||
There was a problem hiding this comment.
hm, this is already up to 2025 in main branch. And I notice this change is not in #3411. Can you merge main into this?
|
zhumin8
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces an upgrade to Spring Cloud 2024 and Spring Boot 3.4.2
Previously approved (#3411)
Changes per module
sm@secret_idin addition to the already existingsm://secret_idformat. Users should move away fromsm://and usesm@instead. Usage ofsm://will raise a warning about this being removed in the future. This has been tested usingspring-framework:6.2.2-SNAPSHOT.Internal changes
QueryMethodEvaluationContextProvidertoValueExpressionDelegateQueryMethodEvaluationContextProvidertoValueExpressionDelegate