Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock EXTERNAL/EXTERNAL_VPC Cloud KMS key creation. #2103

Conversation

modular-magician
Copy link
Collaborator

The external_protection_level_options field had been nested within the attestation field by accident. See hashicorp/terraform-provider-google#15004 for more information about this change..

NOTE: this is the initial deprecation notice, and we are just adding a duplicate set of fields outside of attestation. When the old field is eventually removed, it should not break any CUJs because the current state of things does not allow for successful key creation (malformed requests would be rejected by the server). The old, deprecated field will be removed in the next release.

Release Note Template for Downstream PRs (will be copied)

kms: added top-level `external_protection_level_options` field in `google_kms_crypto_key_version` resource
kms: `attestation.external_protection_level_options` has been deprecated in favor of `external_protection_level_options` in `google_kms_crypto_key_version` 
kms: added `crypto_key_backend` field to `google_kms_crypto_key` resource

Derived from GoogleCloudPlatform/magic-modules#9931

[upstream:a1e15b7437a5b41602e434668bf07434c2873336]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner March 27, 2024 20:23
@modular-magician modular-magician requested review from roaks3 and removed request for a team March 27, 2024 20:23
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician merged commit 2e1369d into GoogleCloudPlatform:main Mar 27, 2024
5 checks passed
@modular-magician modular-magician deleted the downstream-pr-a1e15b7437a5b41602e434668bf07434c2873336 branch November 18, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant