Set config_sync.enabled field to true to fix broken tests
#2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:d7a7ea3848a27c9132200d7073bda400afbda483] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
shuyama1
and removed request for
a team
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform google provider v5.41.0 (released on Aug 12, 2024) introduced a new field
config_sync.enabledto the google_gke_hub_feature_membership resource. The default value of this field is false. However, when the field is omitted from the Terraform resource, Terraform sets the field to false in the ACM Hub API explicitly. This issue causes the Terraform users to fail to install Config Sync unless they set the new field to true explicitly.To mitigate this issue, we enhanced the Hub CLH to throw an error if Config Sync is explicitly disabled and the Git or OCI configuration is set.
Our Terraform users need to set the new field to true explicitly to install Config Sync from v5.41.0. For existing CS installations, upgrading from Terraform versions prior to v5.41.0 to versions >= v5.41.0 does not break users, and does not uninstall Config Sync.
part of hashicorp/terraform-provider-google#14591.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11880