Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how conditions are handled in google_bigtable_instance_iam_* resources #2886

Conversation

modular-magician
Copy link
Collaborator

This PR

  1. Converts existing BigTable IAM acceptance tests to use the context pattern
  2. Updates BigTable IAM code to use policy version 3
  3. Adds new acceptance tests showing conditions can be used and imported

Release Note Template for Downstream PRs (will be copied)

bigtable: fixed an error where BigTable IAM resources could be created with conditions but the condition was not stored in state

Derived from GoogleCloudPlatform/magic-modules#11890

…sources (#11890)

[upstream:54afca9967497515b718b8c4fcc0ef3fdb897f60]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner October 2, 2024 18:12
@modular-magician modular-magician requested review from roaks3 and removed request for a team October 2, 2024 18:12
@modular-magician modular-magician merged commit 9992f2f into GoogleCloudPlatform:main Oct 2, 2024
4 of 5 checks passed
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician deleted the downstream-pr-54afca9967497515b718b8c4fcc0ef3fdb897f60 branch November 18, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant